Skip to content

Commit b64b223

Browse files
refackBethGriggs
authored andcommittedApr 9, 2019
build,win: silence MSVC warning C4129 for V8
Currently we get 13,799 of those per build PR-URL: #27017 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
1 parent ea47189 commit b64b223

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed
 

‎deps/v8/gypfiles/toolchain.gypi

+1
Original file line numberDiff line numberDiff line change
@@ -1395,6 +1395,7 @@
13951395
}, # configurations
13961396
'cflags': [ '-Wno-type-limits', ],
13971397
'msvs_disabled_warnings': [
1398+
4129, # unrecognized character escape sequence (torque-generated)
13981399
4245, # Conversion with signed/unsigned mismatch.
13991400
4267, # Conversion with possible loss of data.
14001401
4324, # Padding structure due to alignment.

0 commit comments

Comments
 (0)
Please sign in to comment.