From b724eaf66dff4e2cd94c7cedd1c3864a80bea910 Mon Sep 17 00:00:00 2001 From: Milad Farazmand Date: Tue, 14 Jan 2020 13:43:14 +0000 Subject: [PATCH] deps: V8: cherry-pick d89f4ef1cd62 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Original commit message: S390x: improve performance by skipping Debug Hook if not needed Change-Id: Ib4b2821f2941cdc131f9c75b89a3baced7554f8d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991802 Reviewed-by: Junliang Yan Commit-Queue: Milad Farazmand Cr-Commit-Position: refs/heads/master@{#65644} Refs: https://github.com/v8/v8/commit/d89f4ef1cd629cb169f0d9efcaefd05ebf09fd3d PR-URL: https://github.com/nodejs/node/pull/31354 Reviewed-By: David Carlier Reviewed-By: Michaƫl Zasso Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: Michael Dawson Reviewed-By: Beth Griggs Reviewed-By: Richard Lau --- common.gypi | 2 +- deps/v8/src/codegen/s390/macro-assembler-s390.cc | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/common.gypi b/common.gypi index c26ed5e0192389..2b61a19a29cad0 100644 --- a/common.gypi +++ b/common.gypi @@ -38,7 +38,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.29', + 'v8_embedder_string': '-node.30', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/src/codegen/s390/macro-assembler-s390.cc b/deps/v8/src/codegen/s390/macro-assembler-s390.cc index 355d536379a1b6..4fc8ae38e602f3 100644 --- a/deps/v8/src/codegen/s390/macro-assembler-s390.cc +++ b/deps/v8/src/codegen/s390/macro-assembler-s390.cc @@ -1336,8 +1336,8 @@ void MacroAssembler::CheckDebugHook(Register fun, Register new_target, ExternalReference debug_hook_active = ExternalReference::debug_hook_on_function_call_address(isolate()); Move(r6, debug_hook_active); - tm(MemOperand(r6), Operand::Zero()); - bne(&skip_hook); + tm(MemOperand(r6), Operand(0xFF)); + beq(&skip_hook); { // Load receiver to pass it later to DebugOnFunctionCall hook.