Skip to content

Commit

Permalink
src: update NODE_MODULE_VERSION to 86
Browse files Browse the repository at this point in the history
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 8.4.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

PR-URL: #33579
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
  • Loading branch information
targos committed Jul 13, 2020
1 parent eba5aaf commit b7cf823
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions doc/abi_version_registry.json
@@ -1,5 +1,6 @@
{
"NODE_MODULE_VERSION": [
{ "modules": 86, "runtime": "node", "variant": "v8_8.4", "versions": "15.0.0-pre" },
{ "modules": 85, "runtime": "electron", "variant": "electron", "versions": "11" },
{ "modules": 84, "runtime": "node", "variant": "v8_8.3", "versions": "15.0.0-pre" },
{ "modules": 83, "runtime": "node", "variant": "v8_8.1", "versions": "14.0.0" },
Expand Down
2 changes: 1 addition & 1 deletion src/node_version.h
Expand Up @@ -89,7 +89,7 @@
* version matching should open a pull request to reserve a number in this
* registry.
*/
#define NODE_MODULE_VERSION 84
#define NODE_MODULE_VERSION 86

// The NAPI_VERSION provided by this version of the runtime. This is the version
// which the Node binary being built supports.
Expand Down

0 comments on commit b7cf823

Please sign in to comment.