Skip to content

Commit b84fd94

Browse files
ronagcodebytere
authored andcommittedMar 30, 2020
crypto: fix performance regression
e559842 made writable/readable computed with a legacy mode if the properties are written to. LazyTransform still unecessarily wrote to these properties causing a performance regression. Fixes: #31739 PR-URL: #31742 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 0b75790 commit b84fd94

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed
 

‎lib/internal/streams/lazy_transform.js

-2
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ module.exports = LazyTransform;
1919

2020
function LazyTransform(options) {
2121
this._options = options;
22-
this.writable = true;
23-
this.readable = true;
2422
}
2523
ObjectSetPrototypeOf(LazyTransform.prototype, stream.Transform.prototype);
2624
ObjectSetPrototypeOf(LazyTransform, stream.Transform);

0 commit comments

Comments
 (0)
Please sign in to comment.