From 95dffe727ac148ba39831993bf506e7130a42cec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Fri, 3 Sep 2021 09:13:43 +0200 Subject: [PATCH 1/2] Revert "build: add windows-2022 to GitHub test matrix" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 13b569c679ca98fa2549ad5c801b3d52a4249d72. V8 9.3 is not compatible. Refs: https://github.com/nodejs/node/issues/39976 PR-URL: https://github.com/nodejs/node/pull/39982 Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: Richard Lau --- .github/workflows/build-windows.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index d489de708d130b..1b0b336f4b8273 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -18,11 +18,7 @@ env: jobs: build-windows: if: github.event.pull_request.draft == false - strategy: - matrix: - windows: [windows-2019, windows-2022] - fail-fast: false - runs-on: ${{ matrix.windows }} + runs-on: windows-latest steps: - uses: actions/checkout@v2 - name: Set up Python ${{ env.PYTHON_VERSION }} From c68faa9575923a1632bfc76eb60bfb2dea036735 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 31 Aug 2021 20:50:31 -0700 Subject: [PATCH 2/2] meta: remove duplicate AUTHORS entry for NigelKibodeaux MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/39967 Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca --- .mailmap | 1 + AUTHORS | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap index 6f714cf4b3430c..efd81d38bc26f7 100644 --- a/.mailmap +++ b/.mailmap @@ -301,6 +301,7 @@ Nebu Pookins Netto Farah Nicholas Kinsey Nick Soggin +Nigel Kibodeaux Nikola Glavina Nikolai Vavilov Nils Kuhnhenn diff --git a/AUTHORS b/AUTHORS index 8a33e24cd989b4..b9ad7e86f12f5c 100644 --- a/AUTHORS +++ b/AUTHORS @@ -1242,7 +1242,7 @@ Dan Villa CodeTheInternet Eric Gonzalez rgoodwin -Nigel Kibodeaux +Nigel Kibodeaux fmizzell cdnadmin Paul Lucas @@ -1772,7 +1772,6 @@ Guilherme Akio Sakae Martin Michaelis Christopher Sidebottom Edward Andrew Robinson -Nigel Kibodeaux Shakeel Mohamed Tobias Kieslich Ruy Adorno