From bac7fe07978394472d2dc999fb58688658183603 Mon Sep 17 00:00:00 2001 From: Robert Nagy Date: Thu, 21 Oct 2021 12:33:00 +0200 Subject: [PATCH] stream: remove no longer necessary ComposeDuplex MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/40545 Reviewed-By: Matteo Collina Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca Reviewed-By: Benjamin Gruenbaum --- lib/internal/streams/compose.js | 24 +----------------------- 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/lib/internal/streams/compose.js b/lib/internal/streams/compose.js index d11a372732caab..03bfa39e9f6f1b 100644 --- a/lib/internal/streams/compose.js +++ b/lib/internal/streams/compose.js @@ -16,28 +16,6 @@ const { }, } = require('internal/errors'); -// This is needed for pre node 17. -class ComposeDuplex extends Duplex { - constructor(options) { - super(options); - - // https://github.com/nodejs/node/pull/34385 - - if (options?.readable === false) { - this._readableState.readable = false; - this._readableState.ended = true; - this._readableState.endEmitted = true; - } - - if (options?.writable === false) { - this._writableState.writable = false; - this._writableState.ending = true; - this._writableState.ended = true; - this._writableState.finished = true; - } - } -} - module.exports = function compose(...streams) { if (streams.length === 0) { throw new ERR_MISSING_ARGS('streams'); @@ -107,7 +85,7 @@ module.exports = function compose(...streams) { // TODO(ronag): Avoid double buffering. // Implement Writable/Readable/Duplex traits. // See, https://github.com/nodejs/node/pull/33515. - d = new ComposeDuplex({ + d = new Duplex({ // TODO (ronag): highWaterMark? writableObjectMode: !!head?.writableObjectMode, readableObjectMode: !!tail?.writableObjectMode,