From bb26d4f2f88f30ae17e04dca44e7c004f62d0a43 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Thu, 18 Oct 2018 17:45:47 -0700 Subject: [PATCH] meta: clarify fast-track approval Refs: https://github.com/nodejs/node/pull/23725#issuecomment-431202936 PR-URL: https://github.com/nodejs/node/pull/23744 Reviewed-By: Refael Ackermann Reviewed-By: Anna Henningsen Reviewed-By: Richard Lau Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Matheus Marchini Reviewed-By: Vse Mozhet Byt Reviewed-By: Ruben Bridgewater --- COLLABORATOR_GUIDE.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 7dba23dc74e566..7cfc6388c549b5 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -187,7 +187,9 @@ Collaborators that previously approved the pull request. If someone disagrees with the fast-tracking request, remove the label and leave a comment indicating why the pull request should not be fast-tracked. The pull request can be landed once two or more Collaborators approve both the pull request and the -fast-tracking request, and the necessary CI testing is done. +fast-tracking request, and the necessary CI testing is done. A request to +fast-track a PR made by a different Collaborator than the pull-request author +counts as a fast-track approval. ### Testing and CI