Skip to content

Commit bc9453a

Browse files
addaleaxtargos
authored andcommittedApr 22, 2020
test: make sure that inspector tests finish
PR-URL: #32673 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent a5fd29b commit bc9453a

28 files changed

+33
-30
lines changed
 

‎test/parallel/test-inspector-bindings.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -127,4 +127,4 @@ async function doTests() {
127127
await testNoCrashConsoleLogBeforeThrow();
128128
}
129129

130-
doTests();
130+
doTests().then(common.mustCall());

‎test/parallel/test-inspector-esm.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -109,4 +109,4 @@ async function runTest() {
109109
assert.strictEqual((await child.expectShutdown()).exitCode, 55);
110110
}
111111

112-
runTest();
112+
runTest().then(common.mustCall());

‎test/parallel/test-inspector-multisession-js.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ async function test() {
5757
}
5858

5959
const interval = setInterval(() => {}, 1000);
60-
test().then(() => {
60+
test().then(common.mustCall(() => {
6161
clearInterval(interval);
6262
console.log('Done!');
63-
});
63+
}));

‎test/parallel/test-inspector-multisession-ws.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,4 +74,4 @@ async function runTest() {
7474
return child.expectShutdown();
7575
}
7676

77-
runTest();
77+
runTest().then(common.mustCall());

‎test/parallel/test-inspector-reported-host.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ async function test() {
1616
child.kill();
1717
}
1818

19-
test();
19+
test().then(common.mustCall());

‎test/parallel/test-inspector-tracing-domain.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,4 +66,4 @@ async function test() {
6666
console.log('Success');
6767
}
6868

69-
test();
69+
test().then(common.mustCall());

‎test/parallel/test-inspector-wait-for-connection.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,4 +58,4 @@ async function runTests() {
5858
assert.throws(() => require('inspector').waitForDebugger(), re);
5959
}
6060

61-
runTests();
61+
runTests().then(common.mustCall());

‎test/parallel/test-inspector-waiting-for-disconnect.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,4 @@ async function runTest() {
4141
assert.strictEqual((await child.expectShutdown()).exitCode, 55);
4242
}
4343

44-
runTest();
44+
runTest().then(common.mustCall());

‎test/sequential/test-inspector-async-hook-setup-at-inspect-brk.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,4 +46,4 @@ async function runTests() {
4646
assert.strictEqual((await instance.expectShutdown()).exitCode, 55);
4747
}
4848

49-
runTests();
49+
runTests().then(common.mustCall());

‎test/sequential/test-inspector-async-hook-setup-at-signal.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,4 +81,4 @@ async function runTests() {
8181
instance.kill();
8282
}
8383

84-
runTests();
84+
runTests().then(common.mustCall());

‎test/sequential/test-inspector-async-stack-traces-promise-then.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,4 +68,4 @@ function assertArrayIncludes(actual, expected) {
6868
`Expected ${actualString} to contain ${expectedString}.`);
6969
}
7070

71-
runTests();
71+
runTests().then(common.mustCall());

‎test/sequential/test-inspector-async-stack-traces-set-interval.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,4 @@ async function runTests() {
4444
instance.kill();
4545
}
4646

47-
runTests();
47+
runTests().then(common.mustCall());

‎test/sequential/test-inspector-break-e.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,4 @@ async function runTests() {
1818
assert.strictEqual((await instance.expectShutdown()).exitCode, 0);
1919
}
2020

21-
runTests();
21+
runTests().then(common.mustCall());

‎test/sequential/test-inspector-break-when-eval.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,4 +75,4 @@ async function runTests() {
7575
assert.strictEqual((await child.expectShutdown()).exitCode, 0);
7676
}
7777

78-
runTests();
78+
runTests().then(common.mustCall());

‎test/sequential/test-inspector-console.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,4 +34,4 @@ async function runTest() {
3434
session.disconnect();
3535
}
3636

37-
runTest();
37+
runTest().then(common.mustCall());

‎test/sequential/test-inspector-contexts.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -163,4 +163,7 @@ async function testBreakpointHit() {
163163
await pausedPromise;
164164
}
165165

166-
testContextCreatedAndDestroyed().then(common.mustCall(testBreakpointHit));
166+
(async function() {
167+
await testContextCreatedAndDestroyed();
168+
await testBreakpointHit();
169+
})().then(common.mustCall());

‎test/sequential/test-inspector-debug-brk-flag.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ async function testBreakpointOnStart(session) {
2727
}
2828

2929
async function runTests() {
30-
const child = new NodeInstance(['--inspect', '--debug-brk']);
30+
const child = new NodeInstance(['--inspect', '--inspect-brk']);
3131
const session = await child.connectInspectorSession();
3232

3333
await testBreakpointOnStart(session);
@@ -36,4 +36,4 @@ async function runTests() {
3636
assert.strictEqual((await child.expectShutdown()).exitCode, 55);
3737
}
3838

39-
runTests();
39+
runTests().then(common.mustCall());

‎test/sequential/test-inspector-debug-end.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,4 @@ async function runTest() {
4141
await testSessionNoCrash();
4242
}
4343

44-
runTest();
44+
runTest().then(common.mustCall());

‎test/sequential/test-inspector-exception.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,4 @@ async function runTest() {
4141
assert.strictEqual((await child.expectShutdown()).exitCode, 1);
4242
}
4343

44-
runTest();
44+
runTest().then(common.mustCall());

‎test/sequential/test-inspector-ip-detection.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,4 @@ async function test() {
4343
instance.kill();
4444
}
4545

46-
test();
46+
test().then(common.mustCall());

‎test/sequential/test-inspector-not-blocked-on-idle.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ async function runTests() {
1717
node.kill();
1818
}
1919

20-
runTests();
20+
runTests().then(common.mustCall());

‎test/sequential/test-inspector-overwrite-config.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,4 @@ async function runTests() {
4141
assert.ok(asserted, 'log statement did not reach the inspector');
4242
}
4343

44-
runTests();
44+
runTests().then(common.mustCall());

‎test/sequential/test-inspector-resource-name-to-url.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,4 @@ common.skipIfInspectorDisabled();
3737
const { params: { url } } = await promise;
3838
strictEqual(url, expected);
3939
}
40-
})();
40+
})().then(common.mustCall());

‎test/sequential/test-inspector-runtime-evaluate-with-timeout.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,4 @@ common.skipIfInspectorDisabled();
2222
}
2323
);
2424
session.disconnect();
25-
})();
25+
})().then(common.mustCall());

‎test/sequential/test-inspector-scriptparsed-context.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,4 +83,4 @@ async function runTests() {
8383
assert.strictEqual((await instance.expectShutdown()).exitCode, 0);
8484
}
8585

86-
runTests();
86+
runTests().then(common.mustCall());

‎test/sequential/test-inspector-stop-profile-after-done.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,4 @@ async function runTests() {
2727
assert.strictEqual((await child.expectShutdown()).exitCode, 0);
2828
}
2929

30-
runTests();
30+
runTests().then(common.mustCall());

‎test/sequential/test-inspector-stress-http.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,4 @@ async function runTest() {
2828
return child.kill();
2929
}
3030

31-
runTest();
31+
runTest().then(common.mustCall());

‎test/sequential/test-inspector.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -314,4 +314,4 @@ async function runTest() {
314314
);
315315
}
316316

317-
runTest();
317+
runTest().then(common.mustCall());

0 commit comments

Comments
 (0)
Please sign in to comment.