Skip to content

Commit

Permalink
build: skip cctest on Windows shared lib build
Browse files Browse the repository at this point in the history
cctest depends on some internal APIs which don't declare
`__declspec(dllexport)` and causes build failure when building
node as shared lib on Windows. Since we already have good test
coverage in static lib, we decide to skip the cctest in shared
lib build on Windows.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>

Backport-PR-URL: #25758
PR-URL: #21228
Reviewed-By: Refael Ackermann <refack@gmail.com>
  • Loading branch information
yhwang authored and BethGriggs committed Mar 20, 2019
1 parent 6352288 commit c07ba96
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
4 changes: 4 additions & 0 deletions node.gyp
Expand Up @@ -961,6 +961,10 @@
'OTHER_LDFLAGS': [ '-Wl,-rpath,@loader_path', ],
},
}],
# Skip cctest while building shared lib node for Windows
[ 'OS=="win" and node_shared=="true"', {
'type': 'none',
}],
],
}
], # end targets
Expand Down
1 change: 1 addition & 0 deletions vcbuild.bat
Expand Up @@ -474,6 +474,7 @@ if errorlevel 1 goto exit
if "%test_args%"=="" goto test-v8
if "%config%"=="Debug" set test_args=--mode=debug %test_args%
if "%config%"=="Release" set test_args=--mode=release %test_args%
if not exist %config%\cctest.exe goto run-test-py
echo running 'cctest %cctest_args%'
"%config%\cctest" %cctest_args%
REM when building a static library there's no binary to run tests
Expand Down

0 comments on commit c07ba96

Please sign in to comment.