From c07ba9681fd16c5aaa8dce66478efa6a80372d2a Mon Sep 17 00:00:00 2001 From: Yihong Wang Date: Tue, 24 Jul 2018 13:44:09 -0700 Subject: [PATCH] build: skip cctest on Windows shared lib build cctest depends on some internal APIs which don't declare `__declspec(dllexport)` and causes build failure when building node as shared lib on Windows. Since we already have good test coverage in static lib, we decide to skip the cctest in shared lib build on Windows. Signed-off-by: Yihong Wang Backport-PR-URL: https://github.com/nodejs/node/pull/25758 PR-URL: https://github.com/nodejs/node/pull/21228 Reviewed-By: Refael Ackermann --- node.gyp | 4 ++++ vcbuild.bat | 1 + 2 files changed, 5 insertions(+) diff --git a/node.gyp b/node.gyp index 43ba985df54111..2967b5efc3def5 100644 --- a/node.gyp +++ b/node.gyp @@ -961,6 +961,10 @@ 'OTHER_LDFLAGS': [ '-Wl,-rpath,@loader_path', ], }, }], + # Skip cctest while building shared lib node for Windows + [ 'OS=="win" and node_shared=="true"', { + 'type': 'none', + }], ], } ], # end targets diff --git a/vcbuild.bat b/vcbuild.bat index 43962324857bed..7143d841a4e2bc 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -474,6 +474,7 @@ if errorlevel 1 goto exit if "%test_args%"=="" goto test-v8 if "%config%"=="Debug" set test_args=--mode=debug %test_args% if "%config%"=="Release" set test_args=--mode=release %test_args% +if not exist %config%\cctest.exe goto run-test-py echo running 'cctest %cctest_args%' "%config%\cctest" %cctest_args% REM when building a static library there's no binary to run tests