diff --git a/benchmark/_test-double-benchmarker.js b/benchmark/_test-double-benchmarker.js index 89843d4616cc50..2d05f9fd92be2b 100644 --- a/benchmark/_test-double-benchmarker.js +++ b/benchmark/_test-double-benchmarker.js @@ -46,7 +46,7 @@ function run() { } } else { // HTTP/2 const client = http.connect(url); - client.on('error', (e) => { throw e; }); + client.on('error', () => {}); request(client.request(), client); } } diff --git a/benchmark/http2/compat.js b/benchmark/http2/compat.js index 2c7e732b07f0a5..9ca7ab1ba08ef7 100644 --- a/benchmark/http2/compat.js +++ b/benchmark/http2/compat.js @@ -24,9 +24,10 @@ function main({ requests, streams, clients, duration }) { res.destroy(); }); }); - server.listen(common.PORT, () => { + server.listen(0, () => { bench.http({ path: '/', + port: server.address().port, requests, maxConcurrentStreams: streams, clients, diff --git a/benchmark/http2/headers.js b/benchmark/http2/headers.js index 56799da1987e53..886f64be1c8b7b 100644 --- a/benchmark/http2/headers.js +++ b/benchmark/http2/headers.js @@ -1,7 +1,6 @@ 'use strict'; const common = require('../common.js'); -const PORT = common.PORT; const bench = common.createBenchmark(main, { n: [1e3], @@ -32,8 +31,8 @@ function main({ n, nheaders }) { stream.respond(); stream.end('Hi!'); }); - server.listen(PORT, () => { - const client = http2.connect(`http://localhost:${PORT}/`, { + server.listen(0, () => { + const client = http2.connect(`http://localhost:${server.address().port}/`, { maxHeaderListPairs: 20000 }); diff --git a/benchmark/http2/respond-with-fd.js b/benchmark/http2/respond-with-fd.js index 5bf5988d16a64c..547b6900b61f48 100644 --- a/benchmark/http2/respond-with-fd.js +++ b/benchmark/http2/respond-with-fd.js @@ -25,10 +25,11 @@ function main({ requests, streams, clients, duration }) { stream.respondWithFD(fd); stream.on('error', (err) => {}); }); - server.listen(common.PORT, () => { + server.listen(0, () => { bench.http({ path: '/', requests, + port: server.address().port, maxConcurrentStreams: streams, clients, duration, diff --git a/benchmark/http2/simple.js b/benchmark/http2/simple.js index 929c4c655e1295..d9ac513d3c3e68 100644 --- a/benchmark/http2/simple.js +++ b/benchmark/http2/simple.js @@ -22,9 +22,10 @@ function main({ requests, streams, clients, duration }) { out.pipe(stream); stream.on('error', (err) => {}); }); - server.listen(common.PORT, () => { + server.listen(0, () => { bench.http({ path: '/', + port: server.address().port, requests, maxConcurrentStreams: streams, clients, diff --git a/benchmark/http2/write.js b/benchmark/http2/write.js index 7ea8b2c02da650..caf93e2f2b62d5 100644 --- a/benchmark/http2/write.js +++ b/benchmark/http2/write.js @@ -26,9 +26,10 @@ function main({ streams, length, size, duration }) { } write(); }); - server.listen(common.PORT, () => { + server.listen(0, () => { bench.http({ path: '/', + port: server.address().port, requests: 10000, duration, maxConcurrentStreams: streams,