diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index 44d7529b2a2e54..5ab5f98739f579 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -32,7 +32,7 @@ jobs: if: github.event.pull_request.draft == false strategy: matrix: - windows: [windows-2019, windows-2022] + windows: [windows-2019] fail-fast: false runs-on: ${{ matrix.windows }} steps: diff --git a/.github/workflows/coverage-windows.yml b/.github/workflows/coverage-windows.yml index 231f3b1ed7ec13..dde4f30f8f2909 100644 --- a/.github/workflows/coverage-windows.yml +++ b/.github/workflows/coverage-windows.yml @@ -33,7 +33,7 @@ env: jobs: coverage-windows: if: github.event.pull_request.draft == false - runs-on: windows-latest + runs-on: windows-2019 steps: - uses: actions/checkout@v3 with: diff --git a/.github/workflows/test-asan.yml b/.github/workflows/test-asan.yml index 29e545657002eb..87cf9edf672d47 100644 --- a/.github/workflows/test-asan.yml +++ b/.github/workflows/test-asan.yml @@ -30,6 +30,7 @@ concurrency: cancel-in-progress: true env: + ASAN_OPTIONS: intercept_tls_get_addr=0 PYTHON_VERSION: '3.10' FLAKY_TESTS: dontcare diff --git a/.mailmap b/.mailmap index 6ee2b48dceb82b..226c06fabb4db8 100644 --- a/.mailmap +++ b/.mailmap @@ -198,8 +198,6 @@ Hassaan Pasha Hendrik Schwalm Henry Chin Herbert Vojčík -Zeyu "Alex" Yang -Zeyu "Alex" Yang Hitesh Kanwathirtha Icer Liang Igor Savin @@ -382,6 +380,7 @@ Oluwaseun Omoyajowo OneNail Onne Gorter Oscar Martinez +Paolo Insogna Paul Graham Paul Querna Pedro Lima @@ -564,6 +563,8 @@ Yuta Hiroto Zach Bjornson Zachary Scott Zachary Vacura +Zeyu "Alex" Yang +Zeyu "Alex" Yang Zoran Tomicic Сковорода Никита Андреевич 隋鑫磊 diff --git a/doc/api/modules.md b/doc/api/modules.md index 0c860af60d1446..18e6d29797770e 100644 --- a/doc/api/modules.md +++ b/doc/api/modules.md @@ -562,7 +562,7 @@ wrapper that looks like the following: By doing this, Node.js achieves a few things: -* It keeps top-level variables (defined with `var`, `const` or `let`) scoped to +* It keeps top-level variables (defined with `var`, `const`, or `let`) scoped to the module rather than the global object. * It helps to provide some global-looking variables that are actually specific to the module, such as: diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js index ea9482e69dc904..9ae66a8e073442 100644 --- a/lib/internal/fs/promises.js +++ b/lib/internal/fs/promises.js @@ -528,7 +528,7 @@ async function read(handle, bufferOrParams, offset, length, position) { offset = 0, length = buffer.byteLength - offset, position = null - } = offset ?? ObjectCreate(null)); + } = offset); } if (offset == null) {