Skip to content

Commit c4e17cf

Browse files
masx200BethGriggs
authored andcommittedDec 15, 2020
http2: add has method to proxySocketHandler
PR-URL: #35197 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 30cd797 commit c4e17cf

File tree

2 files changed

+44
-0
lines changed

2 files changed

+44
-0
lines changed
 

‎lib/internal/http2/compat.js

+5
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,11 @@ function resumeStream(stream) {
181181
}
182182

183183
const proxySocketHandler = {
184+
has(stream, prop) {
185+
const ref = stream.session !== undefined ? stream.session[kSocket] : stream;
186+
return (prop in stream) || (prop in ref);
187+
},
188+
184189
get(stream, prop) {
185190
switch (prop) {
186191
case 'on':
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
'use strict';
2+
const common = require('../common');
3+
if (!common.hasCrypto) {
4+
common.skip('missing crypto');
5+
}
6+
7+
const fixtures = require('../common/fixtures');
8+
const assert = require('assert');
9+
const http2 = require('http2');
10+
11+
const serverOptions = {
12+
key: fixtures.readKey('agent1-key.pem'),
13+
cert: fixtures.readKey('agent1-cert.pem')
14+
};
15+
const server = http2.createSecureServer(serverOptions, common.mustCall(
16+
(req, res) => {
17+
const request = req;
18+
assert.strictEqual(request.socket.encrypted, true);
19+
assert.ok('encrypted' in request.socket);
20+
res.end();
21+
}
22+
));
23+
server.listen(common.mustCall(() => {
24+
const port = server.address().port;
25+
const client = http2.connect('https://localhost:' + port, {
26+
ca: fixtures.readKey('agent1-cert.pem'),
27+
rejectUnauthorized: false
28+
});
29+
const req = client.request({});
30+
req.on('response', common.mustCall((headers, flags) => {
31+
console.log(headers);
32+
server.close(common.mustCall(() => {
33+
}));
34+
}));
35+
req.on('end', common.mustCall(() => {
36+
client.close();
37+
}));
38+
req.end();
39+
}));

0 commit comments

Comments
 (0)
Please sign in to comment.