Skip to content

Commit

Permalink
tools: disable x86 safe exception handlers in V8
Browse files Browse the repository at this point in the history
PR-URL: #35415
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
  • Loading branch information
targos committed Oct 18, 2020
1 parent 6cfba9f commit c55f661
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions tools/v8_gypfiles/toolchain.gypi
Expand Up @@ -1362,5 +1362,13 @@
4724, # https://crbug.com/v8/7771
4800, # Forcing value to bool.
],
# Relevant only for x86.
# Refs: https://github.com/nodejs/node/pull/25852
# Refs: https://docs.microsoft.com/en-us/cpp/build/reference/safeseh-image-has-safe-exception-handlers
'msvs_settings': {
'VCLinkerTool': {
'ImageHasSafeExceptionHandlers': 'false',
},
},
}, # target_defaults
}

0 comments on commit c55f661

Please sign in to comment.