From c55f661551d7368778ae6f9adc584467151bce8a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Wed, 14 Oct 2020 12:09:06 +0200 Subject: [PATCH] tools: disable x86 safe exception handlers in V8 PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By: Rich Trott Reviewed-By: Jiawen Geng Reviewed-By: Daniel Bevenius Reviewed-By: Matteo Collina Reviewed-By: Myles Borins --- tools/v8_gypfiles/toolchain.gypi | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/v8_gypfiles/toolchain.gypi b/tools/v8_gypfiles/toolchain.gypi index d4bad70d45025e..d6cc53f8493ecf 100644 --- a/tools/v8_gypfiles/toolchain.gypi +++ b/tools/v8_gypfiles/toolchain.gypi @@ -1362,5 +1362,13 @@ 4724, # https://crbug.com/v8/7771 4800, # Forcing value to bool. ], + # Relevant only for x86. + # Refs: https://github.com/nodejs/node/pull/25852 + # Refs: https://docs.microsoft.com/en-us/cpp/build/reference/safeseh-image-has-safe-exception-handlers + 'msvs_settings': { + 'VCLinkerTool': { + 'ImageHasSafeExceptionHandlers': 'false', + }, + }, }, # target_defaults }