From c67d3d0c3caf74795871f813dbef2ec3fc196e58 Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Thu, 20 Sep 2018 12:13:39 -0400 Subject: [PATCH] src: remove calls to SetWrapperClassId() We have migrated from the deprecated RetainedObjectInfo API to the new EmbedderGraph API, so there is no need to take care of wrapper class ids anymore since they are dedicated to the deprecated API (the new API uses a graph instead of ids to retrieve info about nodes). PR-URL: https://github.com/nodejs/node/pull/22975 Refs: https://github.com/nodejs/node/pull/21741 Reviewed-By: James M Snell Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig --- src/async_wrap.cc | 3 --- src/async_wrap.h | 2 -- src/node_buffer.cc | 3 --- 3 files changed, 8 deletions(-) diff --git a/src/async_wrap.cc b/src/async_wrap.cc index f697679399b76e..b04ab6808704b1 100644 --- a/src/async_wrap.cc +++ b/src/async_wrap.cc @@ -556,9 +556,6 @@ AsyncWrap::AsyncWrap(Environment* env, CHECK_NE(provider, PROVIDER_NONE); CHECK_GE(object->InternalFieldCount(), 1); - // Shift provider value over to prevent id collision. - persistent().SetWrapperClassId(NODE_ASYNC_ID_OFFSET + provider_type_); - // Use AsyncReset() call to execute the init() callbacks. AsyncReset(execution_async_id, silent); } diff --git a/src/async_wrap.h b/src/async_wrap.h index b10676ce1d092c..50864837d62787 100644 --- a/src/async_wrap.h +++ b/src/async_wrap.h @@ -31,8 +31,6 @@ namespace node { -#define NODE_ASYNC_ID_OFFSET 0xA1C - #define NODE_ASYNC_NON_CRYPTO_PROVIDER_TYPES(V) \ V(NONE) \ V(DNSCHANNEL) \ diff --git a/src/node_buffer.cc b/src/node_buffer.cc index dd285156b5644b..8642477db4d927 100644 --- a/src/node_buffer.cc +++ b/src/node_buffer.cc @@ -33,8 +33,6 @@ #include #include -#define BUFFER_ID 0xB0E4 - #define MIN(a, b) ((a) < (b) ? (a) : (b)) #define THROW_AND_RETURN_UNLESS_BUFFER(env, obj) \ @@ -144,7 +142,6 @@ CallbackInfo::CallbackInfo(Isolate* isolate, CHECK_NOT_NULL(data_); persistent_.SetWeak(this, WeakCallback, v8::WeakCallbackType::kParameter); - persistent_.SetWrapperClassId(BUFFER_ID); isolate->AdjustAmountOfExternalAllocatedMemory(sizeof(*this)); }