Skip to content

Commit c6d0a66

Browse files
mhdawsonMylesBorins
authored andcommittedApr 16, 2018
n-api: bump version of n-api supported
Bump the version due to additions to the api. Backport-PR-URL: #19447 PR-URL: #19497 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 71acb52 commit c6d0a66

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed
 

‎src/node_version.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,6 @@
6262
#define NODE_MODULE_VERSION 48 /* Node.js v6.0.0 */
6363

6464
// the NAPI_VERSION provided by this version of the runtime
65-
#define NAPI_VERSION 2
65+
#define NAPI_VERSION 3
6666

6767
#endif // SRC_NODE_VERSION_H_

‎test/addons-napi/test_general/test.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ assert.strictEqual(test_general.testGetPrototype(extendedObject),
3232
assert.notStrictEqual(test_general.testGetPrototype(baseObject),
3333
test_general.testGetPrototype(extendedObject));
3434

35-
// test version management funcitons
36-
// expected version is currently 1
37-
assert.strictEqual(test_general.testGetVersion(), 2);
35+
// test version management functions
36+
// expected version is currently 3
37+
assert.strictEqual(test_general.testGetVersion(), 3);
3838

3939
const [ major, minor, patch, release ] = test_general.testGetNodeVersion();
4040
assert.strictEqual(process.version.split('-')[0],

0 commit comments

Comments
 (0)
Please sign in to comment.