From c6d0a66ef2f74b3d76b6c738f7fb7ac8710c6b9d Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 20 Mar 2018 17:14:24 -0400 Subject: [PATCH] n-api: bump version of n-api supported Bump the version due to additions to the api. Backport-PR-URL: https://github.com/nodejs/node/pull/19447 PR-URL: https://github.com/nodejs/node/pull/19497 Reviewed-By: Colin Ihrig Reviewed-By: Trivikram Kamat Reviewed-By: James M Snell Reviewed-By: Ruben Bridgewater --- src/node_version.h | 2 +- test/addons-napi/test_general/test.js | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/node_version.h b/src/node_version.h index 843e5b524d533f..e71ed35478e3b7 100644 --- a/src/node_version.h +++ b/src/node_version.h @@ -62,6 +62,6 @@ #define NODE_MODULE_VERSION 48 /* Node.js v6.0.0 */ // the NAPI_VERSION provided by this version of the runtime -#define NAPI_VERSION 2 +#define NAPI_VERSION 3 #endif // SRC_NODE_VERSION_H_ diff --git a/test/addons-napi/test_general/test.js b/test/addons-napi/test_general/test.js index d43a1c69ba0c43..4faf508d5db145 100644 --- a/test/addons-napi/test_general/test.js +++ b/test/addons-napi/test_general/test.js @@ -32,9 +32,9 @@ assert.strictEqual(test_general.testGetPrototype(extendedObject), assert.notStrictEqual(test_general.testGetPrototype(baseObject), test_general.testGetPrototype(extendedObject)); -// test version management funcitons -// expected version is currently 1 -assert.strictEqual(test_general.testGetVersion(), 2); +// test version management functions +// expected version is currently 3 +assert.strictEqual(test_general.testGetVersion(), 3); const [ major, minor, patch, release ] = test_general.testGetNodeVersion(); assert.strictEqual(process.version.split('-')[0],