From c77abf5a892145a930b1174eb420b8b804009ef8 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Sun, 18 Apr 2021 15:32:12 -0400 Subject: [PATCH] test: use .test domain for not found address While it is extremely unlikely that `.fhqwhgads` will become a valid domain, we should, where possible, use one of the reserved domains for testing. Refs: https://tools.ietf.org/html/rfc2606 PR-URL: https://github.com/nodejs/node/pull/38286 Refs: https://github.com/nodejs/node/pull/38282 Reviewed-By: Colin Ihrig Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca --- test/common/internet.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/common/internet.js b/test/common/internet.js index 1c53587fb6dbf7..accea74969e276 100644 --- a/test/common/internet.js +++ b/test/common/internet.js @@ -24,7 +24,7 @@ const addresses = { MX_HOST: 'nodejs.org', // On some systems, .invalid returns a server failure/try again rather than // record not found. Use this to guarantee record not found. - NOT_FOUND: 'come.on.fhqwhgads', + NOT_FOUND: 'come.on.fhqwhgads.test', // A host with SRV records registered SRV_HOST: '_jabber._tcp.google.com', // A host with PTR records registered