From c7f29b24a6d62782b6d0a82ff8016bef76b4a461 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Wed, 1 Feb 2023 10:46:55 +0100 Subject: [PATCH] test: add trailing commas in `test/known_issues` PR-URL: https://github.com/nodejs/node/pull/46408 Reviewed-By: Moshe Atlow Reviewed-By: Gireesh Punathil --- test/.eslintrc.yaml | 1 - .../test-dgram-bind-shared-ports-after-port-0.js | 2 +- test/known_issues/test-http-path-contains-unicode.js | 2 +- test/known_issues/test-repl-require-context.js | 2 +- test/known_issues/test-stdin-is-always-net.socket.js | 2 +- test/known_issues/test-url-parse-conformance.js | 2 +- test/known_issues/test-vm-ownkeys.js | 2 +- test/known_issues/test-vm-ownpropertynames.js | 2 +- test/known_issues/test-vm-ownpropertysymbols.js | 2 +- test/known_issues/test-vm-timeout-escape-nexttick.js | 6 +++--- test/known_issues/test-vm-timeout-escape-queuemicrotask.js | 6 +++--- 11 files changed, 14 insertions(+), 15 deletions(-) diff --git a/test/.eslintrc.yaml b/test/.eslintrc.yaml index 16e7227f65668f..5980fcd624db66 100644 --- a/test/.eslintrc.yaml +++ b/test/.eslintrc.yaml @@ -77,7 +77,6 @@ overrides: - es-module/*.js - es-module/*.mjs - js-native-api/*/*.js - - known_issues/*.js - parallel/*.js - parallel/*.mjs - pummel/*.js diff --git a/test/known_issues/test-dgram-bind-shared-ports-after-port-0.js b/test/known_issues/test-dgram-bind-shared-ports-after-port-0.js index 089a5836520059..9d668b702880e7 100644 --- a/test/known_issues/test-dgram-bind-shared-ports-after-port-0.js +++ b/test/known_issues/test-dgram-bind-shared-ports-after-port-0.js @@ -51,6 +51,6 @@ if (cluster.isPrimary) { socket1.on('error', PRT1 === 0 ? () => {} : assert.fail); socket1.bind( { address: common.localhostIPv4, port: PRT1, exclusive: false }, - () => process.send({ message: 'success', port1: socket1.address().port }) + () => process.send({ message: 'success', port1: socket1.address().port }), ); } diff --git a/test/known_issues/test-http-path-contains-unicode.js b/test/known_issues/test-http-path-contains-unicode.js index 8373f1d2159e01..1e063a3e70fad2 100644 --- a/test/known_issues/test-http-path-contains-unicode.js +++ b/test/known_issues/test-http-path-contains-unicode.js @@ -26,7 +26,7 @@ server.listen(0, () => { http.request({ port: server.address().port, path: expected, - method: 'GET' + method: 'GET', }, common.mustCall(function(res) { res.resume(); })).on('error', function(e) { diff --git a/test/known_issues/test-repl-require-context.js b/test/known_issues/test-repl-require-context.js index 2b8737b8671669..193a65eab2dc86 100644 --- a/test/known_issues/test-repl-require-context.js +++ b/test/known_issues/test-repl-require-context.js @@ -11,7 +11,7 @@ const fixture = path('is-object.js'); const r = repl.start({ input: inputStream, output: outputStream, - useGlobal: false + useGlobal: false, }); let output = ''; diff --git a/test/known_issues/test-stdin-is-always-net.socket.js b/test/known_issues/test-stdin-is-always-net.socket.js index 8db33bd7a5ce37..c8dfd4d2ebd995 100644 --- a/test/known_issues/test-stdin-is-always-net.socket.js +++ b/test/known_issues/test-stdin-is-always-net.socket.js @@ -14,7 +14,7 @@ if (process.argv[2] === 'child') { const proc = spawn( process.execPath, [__filename, 'child'], - { stdio: 'ignore' } + { stdio: 'ignore' }, ); // To double-check this test, set stdio to 'pipe' and uncomment the line below. // proc.stderr.pipe(process.stderr); diff --git a/test/known_issues/test-url-parse-conformance.js b/test/known_issues/test-url-parse-conformance.js index 7be8c16099df59..c9fdbba9a067dd 100644 --- a/test/known_issues/test-url-parse-conformance.js +++ b/test/known_issues/test-url-parse-conformance.js @@ -6,7 +6,7 @@ const url = require('url'); const assert = require('assert'); const fixtures = require('../common/fixtures'); const tests = require( - fixtures.path('wpt', 'url', 'resources', 'urltestdata.json') + fixtures.path('wpt', 'url', 'resources', 'urltestdata.json'), ); let failed = 0; diff --git a/test/known_issues/test-vm-ownkeys.js b/test/known_issues/test-vm-ownkeys.js index f245b0f7b52a37..9d1bae72b50c28 100644 --- a/test/known_issues/test-vm-ownkeys.js +++ b/test/known_issues/test-vm-ownkeys.js @@ -8,7 +8,7 @@ const sym1 = Symbol('1'); const sym2 = Symbol('2'); const sandbox = { a: true, - [sym1]: true + [sym1]: true, }; Object.defineProperty(sandbox, 'b', { value: true }); Object.defineProperty(sandbox, sym2, { value: true }); diff --git a/test/known_issues/test-vm-ownpropertynames.js b/test/known_issues/test-vm-ownpropertynames.js index d1c03186ab19ee..41f6822ee1a47f 100644 --- a/test/known_issues/test-vm-ownpropertynames.js +++ b/test/known_issues/test-vm-ownpropertynames.js @@ -8,7 +8,7 @@ const sym1 = Symbol('1'); const sym2 = Symbol('2'); const sandbox = { a: true, - [sym1]: true + [sym1]: true, }; Object.defineProperty(sandbox, 'b', { value: true }); Object.defineProperty(sandbox, sym2, { value: true }); diff --git a/test/known_issues/test-vm-ownpropertysymbols.js b/test/known_issues/test-vm-ownpropertysymbols.js index 2f501627907164..676133cc9ecaea 100644 --- a/test/known_issues/test-vm-ownpropertysymbols.js +++ b/test/known_issues/test-vm-ownpropertysymbols.js @@ -8,7 +8,7 @@ const sym1 = Symbol('1'); const sym2 = Symbol('2'); const sandbox = { a: true, - [sym1]: true + [sym1]: true, }; Object.defineProperty(sandbox, 'b', { value: true }); Object.defineProperty(sandbox, sym2, { value: true }); diff --git a/test/known_issues/test-vm-timeout-escape-nexttick.js b/test/known_issues/test-vm-timeout-escape-nexttick.js index c6967cd742f9f3..6555370820f1f7 100644 --- a/test/known_issues/test-vm-timeout-escape-nexttick.js +++ b/test/known_issues/test-vm-timeout-escape-nexttick.js @@ -36,11 +36,11 @@ for (let i = 0; i < 4; i++) { { hrtime, nextTick, - loop + loop, }, - { timeout: common.platformTimeout(10) } + { timeout: common.platformTimeout(10) }, ); }, { - code: 'ERR_SCRIPT_EXECUTION_TIMEOUT' + code: 'ERR_SCRIPT_EXECUTION_TIMEOUT', }); } diff --git a/test/known_issues/test-vm-timeout-escape-queuemicrotask.js b/test/known_issues/test-vm-timeout-escape-queuemicrotask.js index c8333bd044702b..526bf9a9fab385 100644 --- a/test/known_issues/test-vm-timeout-escape-queuemicrotask.js +++ b/test/known_issues/test-vm-timeout-escape-queuemicrotask.js @@ -33,11 +33,11 @@ assert.throws(() => { { hrtime, queueMicrotask, - loop + loop, }, - { timeout, microtaskMode: 'afterScriptRun' } + { timeout, microtaskMode: 'afterScriptRun' }, ); }, { code: 'ERR_SCRIPT_EXECUTION_TIMEOUT', - message: `Script execution timed out after ${timeout}ms` + message: `Script execution timed out after ${timeout}ms`, });