Skip to content

Commit c8383dd

Browse files
jasnelltargos
authored andcommittedMay 1, 2021
doc: revoke deprecation of legacy url, change status to legacy
Signed-off-by: James M Snell <jasnell@gmail.com> Fixes: #25099 PR-URL: #37784 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
1 parent e34aace commit c8383dd

File tree

2 files changed

+29
-6
lines changed

2 files changed

+29
-6
lines changed
 

‎doc/api/deprecations.md

+4-1
Original file line numberDiff line numberDiff line change
@@ -2147,12 +2147,15 @@ future release.
21472147
### DEP0116: Legacy URL API
21482148
<!-- YAML
21492149
changes:
2150+
- version: REPLACEME
2151+
pr-url: https://github.com/nodejs/node/pull/37784
2152+
description: Deprecation revoked. Status changed to "Legacy".
21502153
- version: v11.0.0
21512154
pr-url: https://github.com/nodejs/node/pull/22715
21522155
description: Documentation-only deprecation.
21532156
-->
21542157

2155-
Type: Documentation-only
2158+
Type: Deprecation revoked
21562159

21572160
The [Legacy URL API][] is deprecated. This includes [`url.format()`][],
21582161
[`url.parse()`][], [`url.resolve()`][], and the [legacy `urlObject`][]. Please

‎doc/api/url.md

+25-5
Original file line numberDiff line numberDiff line change
@@ -1013,18 +1013,29 @@ pathToFileURL('/some/path%.c'); // Correct: file:///some/path%25.c (POSIX)
10131013

10141014
## Legacy URL API
10151015
<!-- YAML
1016-
deprecated: v11.0.0
1016+
changes:
1017+
- version: REPLACEME
1018+
pr-url: https://github.com/nodejs/node/pull/37784
1019+
description: Deprecation revoked. Status changed to "Legacy".
1020+
- version: v11.0.0
1021+
pr-url: https://github.com/nodejs/node/pull/22715
1022+
description: This API is deprecated.
10171023
-->
10181024

1025+
> Stability: 3 - Legacy: Use the WHATWG URL API instead.
1026+
10191027
### Legacy `urlObject`
10201028
<!-- YAML
10211029
changes:
1030+
- version: REPLACEME
1031+
pr-url: https://github.com/nodejs/node/pull/37784
1032+
description: Deprecation revoked. Status changed to "Legacy".
10221033
- version: v11.0.0
10231034
pr-url: https://github.com/nodejs/node/pull/22715
10241035
description: The Legacy URL API is deprecated. Use the WHATWG URL API.
10251036
-->
10261037

1027-
> Stability: 0 - Deprecated: Use the WHATWG URL API instead.
1038+
> Stability: 3 - Legacy: Use the WHATWG URL API instead.
10281039
10291040
The legacy `urlObject` (`require('url').Url`) is created and returned by the
10301041
`url.parse()` function.
@@ -1130,6 +1141,9 @@ forward-slash characters (`/`) are required following the colon in the
11301141
<!-- YAML
11311142
added: v0.1.25
11321143
changes:
1144+
- version: REPLACEME
1145+
pr-url: https://github.com/nodejs/node/pull/37784
1146+
description: Deprecation revoked. Status changed to "Legacy".
11331147
- version: v11.0.0
11341148
pr-url: https://github.com/nodejs/node/pull/22715
11351149
description: The Legacy URL API is deprecated. Use the WHATWG URL API.
@@ -1141,7 +1155,7 @@ changes:
11411155
times.
11421156
-->
11431157

1144-
> Stability: 0 - Deprecated: Use the WHATWG URL API instead.
1158+
> Stability: 3 - Legacy: Use the WHATWG URL API instead.
11451159
11461160
* `urlObject` {Object|string} A URL object (as returned by `url.parse()` or
11471161
constructed otherwise). If a string, it is converted to an object by passing
@@ -1223,6 +1237,9 @@ The formatting process operates as follows:
12231237
<!-- YAML
12241238
added: v0.1.25
12251239
changes:
1240+
- version: REPLACEME
1241+
pr-url: https://github.com/nodejs/node/pull/37784
1242+
description: Deprecation revoked. Status changed to "Legacy".
12261243
- version: v11.14.0
12271244
pr-url: https://github.com/nodejs/node/pull/26941
12281245
description: The `pathname` property on the returned URL object is now `/`
@@ -1237,7 +1254,7 @@ changes:
12371254
when no query string is present.
12381255
-->
12391256

1240-
> Stability: 0 - Deprecated: Use the WHATWG URL API instead.
1257+
> Stability: 3 - Legacy: Use the WHATWG URL API instead.
12411258
12421259
* `urlString` {string} The URL string to parse.
12431260
* `parseQueryString` {boolean} If `true`, the `query` property will always
@@ -1267,6 +1284,9 @@ incorrect handling of usernames and passwords have been identified.
12671284
<!-- YAML
12681285
added: v0.1.25
12691286
changes:
1287+
- version: REPLACEME
1288+
pr-url: https://github.com/nodejs/node/pull/37784
1289+
description: Deprecation revoked. Status changed to "Legacy".
12701290
- version: v11.0.0
12711291
pr-url: https://github.com/nodejs/node/pull/22715
12721292
description: The Legacy URL API is deprecated. Use the WHATWG URL API.
@@ -1285,7 +1305,7 @@ changes:
12851305
contains a hostname.
12861306
-->
12871307

1288-
> Stability: 0 - Deprecated: Use the WHATWG URL API instead.
1308+
> Stability: 3 - Legacy: Use the WHATWG URL API instead.
12891309
12901310
* `from` {string} The Base URL being resolved against.
12911311
* `to` {string} The HREF URL being resolved.

0 commit comments

Comments
 (0)
Please sign in to comment.