Skip to content

Commit c8541a7

Browse files
bnoordhuistargos
authored andcommittedApr 22, 2020
build: disable libstdc++ debug containers globally
Different parts of the debug build were using differently sized std::vectors due to `_GLIBCXX_DEBUG` sometimes being defined and sometimes not. That ended about as well as you would expect. Remove the flag. Fixes: #30056 PR-URL: #30147 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 5a67177 commit c8541a7

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed
 

‎common.gypi

-4
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,6 @@
2929

3030
'openssl_fips%': '',
3131

32-
# Some STL containers (e.g. std::vector) do not preserve ABI compatibility
33-
# between debug and non-debug mode.
34-
'disable_glibcxx_debug': 1,
35-
3632
# Don't use ICU data file (icudtl.dat) from V8, we use our own.
3733
'icu_use_data_file_flag%': 0,
3834

‎tools/v8_gypfiles/toolchain.gypi

-8
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,6 @@
6464
# Print to stdout on Android.
6565
'v8_android_log_stdout%': 0,
6666

67-
# Force disable libstdc++ debug mode.
68-
'disable_glibcxx_debug%': 0,
69-
7067
'v8_enable_backtrace%': 0,
7168

7269
# Enable profiling support. Only required on Windows.
@@ -1167,11 +1164,6 @@
11671164
# Support for backtrace_symbols.
11681165
'ldflags': [ '-rdynamic' ],
11691166
}],
1170-
['OS=="linux" and disable_glibcxx_debug==0', {
1171-
# Enable libstdc++ debugging facilities to help catch problems
1172-
# early, see http://crbug.com/65151 .
1173-
'defines': ['_GLIBCXX_DEBUG=1',],
1174-
}],
11751167
['OS=="aix"', {
11761168
'ldflags': [ '-Wl,-bbigtoc' ],
11771169
'conditions': [

0 commit comments

Comments
 (0)
Please sign in to comment.