From c9aa6950d16c43f3374a179f7e6b3bb3187fd8b2 Mon Sep 17 00:00:00 2001 From: theanarkh Date: Thu, 20 Oct 2022 22:17:43 +0800 Subject: [PATCH] trace_events: fix getCategories --- src/inspector/tracing_agent.cc | 27 +++++++++++++------ .../parallel/test-inspector-tracing-domain.js | 25 ++++++++++++++--- 2 files changed, 40 insertions(+), 12 deletions(-) diff --git a/src/inspector/tracing_agent.cc b/src/inspector/tracing_agent.cc index 14f55d0cac0ff7..de43cb18063d45 100644 --- a/src/inspector/tracing_agent.cc +++ b/src/inspector/tracing_agent.cc @@ -173,14 +173,25 @@ DispatchResponse TracingAgent::stop() { DispatchResponse TracingAgent::getCategories( std::unique_ptr>* categories) { *categories = Array::create(); - categories->get()->addItem("node"); - categories->get()->addItem("node.async"); - categories->get()->addItem("node.bootstrap"); - categories->get()->addItem("node.fs.sync"); - categories->get()->addItem("node.perf"); - categories->get()->addItem("node.perf.usertiming"); - categories->get()->addItem("node.perf.timerify"); - categories->get()->addItem("v8"); + protocol::Array* categorie_list = categories->get(); + categorie_list->addItem("node"); + categorie_list->addItem("node.async_hooks"); + categorie_list->addItem("node.bootstrap"); + categorie_list->addItem("node.console"); + categorie_list->addItem("node.dns.native"); + categorie_list->addItem("node.net.native"); + categorie_list->addItem("node.environment"); + categorie_list->addItem("node.fs.sync"); + categorie_list->addItem("node.fs_dir.sync"); + categorie_list->addItem("node.fs.async"); + categorie_list->addItem("node.fs_dir.async"); + categorie_list->addItem("node.perf"); + categorie_list->addItem("node.perf.usertiming"); + categorie_list->addItem("node.perf.timerify"); + categorie_list->addItem("node.promises.rejections"); + categorie_list->addItem("node.vm.script"); + categorie_list->addItem("v8"); + categorie_list->addItem("node.http"); return DispatchResponse::OK(); } diff --git a/test/parallel/test-inspector-tracing-domain.js b/test/parallel/test-inspector-tracing-domain.js index 164fbe1cd86b67..33335a8d77a546 100644 --- a/test/parallel/test-inspector-tracing-domain.js +++ b/test/parallel/test-inspector-tracing-domain.js @@ -48,10 +48,27 @@ async function test() { session.on('NodeTracing.dataCollected', (n) => traceNotification = n); session.on('NodeTracing.tracingComplete', () => tracingComplete = true); const { categories } = await post('NodeTracing.getCategories'); - compareIgnoringOrder(['node', 'node.async', 'node.bootstrap', 'node.fs.sync', - 'node.perf', 'node.perf.usertiming', - 'node.perf.timerify', 'v8'], - categories); + compareIgnoringOrder([ + "node", + "node.async_hooks", + "node.bootstrap", + "node.console", + "node.dns.native", + "node.net.native", + "node.environment", + "node.fs.sync", + "node.fs_dir.sync", + "node.fs.async", + "node.fs_dir.async", + "node.perf", + "node.perf.usertiming", + "node.perf.timerify", + "node.promises.rejections", + "node.vm.script", + "v8", + "node.http" + ], + categories); const traceConfig = { includedCategories: ['v8'] }; await post('NodeTracing.start', { traceConfig });