From cfcd57182bca8543e1928bbbc3c7fff4bd880469 Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Wed, 8 Sep 2021 10:03:38 +0200 Subject: [PATCH] src: fix -Wunreachable-code-return error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/40034 Reviewed-By: Michaƫl Zasso Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Anna Henningsen --- src/inspector_agent.cc | 1 - src/node_url.cc | 1 - 2 files changed, 2 deletions(-) diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc index 612ce2b78b41ba..c4a3322c6d972f 100644 --- a/src/inspector_agent.cc +++ b/src/inspector_agent.cc @@ -87,7 +87,6 @@ inline void* StartIoThreadMain(void* unused) { if (agent != nullptr) agent->RequestIoThreadStart(); } - return nullptr; } static int StartDebugSignalHandler() { diff --git a/src/node_url.cc b/src/node_url.cc index d7549e3bc05562..d78cb7a3e1ceb0 100644 --- a/src/node_url.cc +++ b/src/node_url.cc @@ -600,7 +600,6 @@ std::string URLHost::ToString() const { case HostType::H_DOMAIN: case HostType::H_OPAQUE: return value_.domain_or_opaque; - break; case HostType::H_IPV4: { dest.reserve(15); uint32_t value = value_.ipv4;