From d49e0ca73ad0a18c3321e4b44eb759817c1cbef5 Mon Sep 17 00:00:00 2001
From: Gabriel Schulhof <gabriel.schulhof@intel.com>
Date: Tue, 17 Nov 2020 16:43:59 -0800
Subject: [PATCH] benchmark: fix build warnings

The napi/* benchmarks were using an incorrect signature for the V8
add-on init function. This was causing a warning.

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: https://github.com/nodejs/node/pull/36157
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
---
 benchmark/napi/function_args/binding.cc | 4 +++-
 benchmark/napi/function_call/binding.cc | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/benchmark/napi/function_args/binding.cc b/benchmark/napi/function_args/binding.cc
index 2c54dd424d405d..078fe0ee3ea767 100644
--- a/benchmark/napi/function_args/binding.cc
+++ b/benchmark/napi/function_args/binding.cc
@@ -123,7 +123,9 @@ void CallWithArguments(const FunctionCallbackInfo<Value>& args) {
   }
 }
 
-void Initialize(Local<Object> target) {
+void Initialize(Local<Object> target,
+                Local<Value> module,
+                void* data) {
   NODE_SET_METHOD(target, "callWithString", CallWithString);
   NODE_SET_METHOD(target, "callWithLongString", CallWithString);
 
diff --git a/benchmark/napi/function_call/binding.cc b/benchmark/napi/function_call/binding.cc
index 289a94ac3ecc88..570f96f41ec458 100644
--- a/benchmark/napi/function_call/binding.cc
+++ b/benchmark/napi/function_call/binding.cc
@@ -7,7 +7,9 @@ void Hello(const v8::FunctionCallbackInfo<v8::Value>& args) {
   args.GetReturnValue().Set(c++);
 }
 
-void Initialize(v8::Local<v8::Object> target) {
+void Initialize(v8::Local<v8::Object> target,
+                v8::Local<v8::Value> module,
+                void* data) {
   NODE_SET_METHOD(target, "hello", Hello);
 }