From d6e94463b3a8c7b7c986c9c2c05c0cfcd5d2768d Mon Sep 17 00:00:00 2001 From: Yash Ladha Date: Sat, 30 Jan 2021 14:25:32 +0530 Subject: [PATCH] src: add context for TODO comment in env.cc Add more context around the TODO change required for achieving the task. When destructuring the isolate and environment_vars from the environment object, it is leading to recursive dependency and thus not able to refactor it in a better way. PR-URL: https://github.com/nodejs/node/pull/37140 Reviewed-By: Joyee Cheung Reviewed-By: Pooja D P Reviewed-By: Rich Trott --- src/env.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/env.cc b/src/env.cc index ea93574a388a76..2757319b7b62bf 100644 --- a/src/env.cc +++ b/src/env.cc @@ -368,7 +368,8 @@ Environment::Environment(IsolateData* isolate_data, set_env_vars(per_process::system_environment); // TODO(joyeecheung): pass Isolate* and env_vars to it instead of the entire - // env + // env, when the recursive dependency inclusion in "debug-utils.h" is + // resolved. enabled_debug_list_.Parse(this); // We create new copies of the per-Environment option sets, so that it is