From d7174b292eff38f839e47ee913c6a4fa3ab6c019 Mon Sep 17 00:00:00 2001
From: legendecas <legendecas@gmail.com>
Date: Tue, 3 May 2022 00:46:31 +0800
Subject: [PATCH] src: add initial shadow realm support

Add initial shadow realm support behind an off-by-default flag
`--experimental-shadow-realm`.

PR-URL: https://github.com/nodejs/node/pull/42869
Refs: https://github.com/nodejs/node/issues/42528
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
---
 .eslintrc.js                       |  1 +
 doc/api/cli.md                     | 12 +++++++++++-
 doc/node.1                         |  3 +++
 lib/.eslintrc.yaml                 |  4 ++++
 node.gyp                           |  2 ++
 src/api/environment.cc             |  7 +++++++
 src/node_options.cc                |  9 +++++++++
 src/node_options.h                 |  1 +
 src/node_shadow_realm.cc           | 16 ++++++++++++++++
 src/node_shadow_realm.h            | 19 +++++++++++++++++++
 test/parallel/test-shadow-realm.js | 12 ++++++++++++
 11 files changed, 85 insertions(+), 1 deletion(-)
 create mode 100644 src/node_shadow_realm.cc
 create mode 100644 src/node_shadow_realm.h
 create mode 100644 test/parallel/test-shadow-realm.js

diff --git a/.eslintrc.js b/.eslintrc.js
index 6d75f4534fa0b2..1dedcd1bd76e15 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -338,6 +338,7 @@ module.exports = {
     TextEncoderStream: 'readable',
     TransformStream: 'readable',
     TransformStreamDefaultController: 'readable',
+    ShadowRealm: 'readable',
     SubtleCrypto: 'readable',
     WritableStream: 'readable',
     WritableStreamDefaultWriter: 'readable',
diff --git a/doc/api/cli.md b/doc/api/cli.md
index 7b17162c22ebe9..16bf8bcfb5cd37 100644
--- a/doc/api/cli.md
+++ b/doc/api/cli.md
@@ -411,10 +411,18 @@ Disable experimental support for the [Fetch API][].
 
 <!-- YAML
 added: v16.6.0
- -->
+-->
 
 Use this flag to disable top-level await in REPL.
 
+### `--experimental-shadow-realm`
+
+<!-- YAML
+added: REPLACEME
+-->
+
+Use this flag to enable [ShadowRealm][] support.
+
 ### `--experimental-specifier-resolution=mode`
 
 <!-- YAML
@@ -1807,6 +1815,7 @@ Node.js options that are allowed are:
 * `--experimental-modules`
 * `--experimental-network-imports`
 * `--experimental-policy`
+* `--experimental-shadow-realm`
 * `--experimental-specifier-resolution`
 * `--experimental-top-level-await`
 * `--experimental-vm-modules`
@@ -2236,6 +2245,7 @@ done
 [OSSL_PROVIDER-legacy]: https://www.openssl.org/docs/man3.0/man7/OSSL_PROVIDER-legacy.html
 [REPL]: repl.md
 [ScriptCoverage]: https://chromedevtools.github.io/devtools-protocol/tot/Profiler#type-ScriptCoverage
+[ShadowRealm]: https://github.com/tc39/proposal-shadowrealm
 [Source Map]: https://sourcemaps.info/spec.html
 [Subresource Integrity]: https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity
 [V8 JavaScript code coverage]: https://v8project.blogspot.com/2017/12/javascript-code-coverage.html
diff --git a/doc/node.1 b/doc/node.1
index cc1572885c78f3..e9051fea260e77 100644
--- a/doc/node.1
+++ b/doc/node.1
@@ -159,6 +159,9 @@ Enable experimental support for loading modules using `import` over `https:`.
 .It Fl -experimental-policy
 Use the specified file as a security policy.
 .
+.It Fl -experimental-shadow-realm
+Use this flag to enable ShadowRealm support.
+.
 .It Fl -no-experimental-fetch
 Disable experimental support for the Fetch API.
 .
diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml
index fdedac6f30c4f4..2cfbf0894f2a3a 100644
--- a/lib/.eslintrc.yaml
+++ b/lib/.eslintrc.yaml
@@ -89,6 +89,10 @@ rules:
       message: Use `const { Request } = require('internal/deps/undici/undici');` instead of the global.
     - name: Response
       message: Use `const { Response } = require('internal/deps/undici/undici');` instead of the global.
+      # ShadowRealm is not available in primordials because it can be
+      # disabled with --no-harmony-shadow-realm CLI flag.
+    - name: ShadowRealm
+      message: Use `const { ShadowRealm } = globalThis;` instead of the global.
       # SharedArrayBuffer is not available in primordials because it can be
       # disabled with --no-harmony-sharedarraybuffer CLI flag.
     - name: SharedArrayBuffer
diff --git a/node.gyp b/node.gyp
index e8e1d9f93314ba..0af820837f8879 100644
--- a/node.gyp
+++ b/node.gyp
@@ -529,6 +529,7 @@
         'src/node_report_module.cc',
         'src/node_report_utils.cc',
         'src/node_serdes.cc',
+        'src/node_shadow_realm.cc',
         'src/node_snapshotable.cc',
         'src/node_sockaddr.cc',
         'src/node_stat_watcher.cc',
@@ -634,6 +635,7 @@
         'src/node_report.h',
         'src/node_revert.h',
         'src/node_root_certs.h',
+        'src/node_shadow_realm.h',
         'src/node_snapshotable.h',
         'src/node_snapshot_builder.h',
         'src/node_sockaddr.h',
diff --git a/src/api/environment.cc b/src/api/environment.cc
index 315e5c1d03a59d..d4d89f9d56cd58 100644
--- a/src/api/environment.cc
+++ b/src/api/environment.cc
@@ -5,6 +5,7 @@
 #include "node_internals.h"
 #include "node_options-inl.h"
 #include "node_platform.h"
+#include "node_shadow_realm.h"
 #include "node_v8_platform-inl.h"
 #include "node_wasm_web_api.h"
 #include "uv.h"
@@ -264,6 +265,12 @@ void SetIsolateMiscHandlers(v8::Isolate* isolate, const IsolateSettings& s) {
     isolate->SetWasmStreamingCallback(wasm_web_api::StartStreamingCompilation);
   }
 
+  if (per_process::cli_options->get_per_isolate_options()
+          ->experimental_shadow_realm) {
+    isolate->SetHostCreateShadowRealmContextCallback(
+        shadow_realm::HostCreateShadowRealmContextCallback);
+  }
+
   if ((s.flags & SHOULD_NOT_SET_PROMISE_REJECTION_CALLBACK) == 0) {
     auto* promise_reject_cb = s.promise_reject_callback ?
       s.promise_reject_callback : PromiseRejectCallback;
diff --git a/src/node_options.cc b/src/node_options.cc
index e2a051d03c7ede..98f7d5b6e52a0d 100644
--- a/src/node_options.cc
+++ b/src/node_options.cc
@@ -753,6 +753,15 @@ PerIsolateOptionsParser::PerIsolateOptionsParser(
   AddOption(
       "--experimental-top-level-await", "", NoOp{}, kAllowedInEnvironment);
 
+  AddOption("--experimental-shadow-realm",
+            "",
+            &PerIsolateOptions::experimental_shadow_realm,
+            kAllowedInEnvironment);
+  AddOption("--harmony-shadow-realm", "", V8Option{});
+  Implies("--experimental-shadow-realm", "--harmony-shadow-realm");
+  Implies("--harmony-shadow-realm", "--experimental-shadow-realm");
+  ImpliesNot("--no-harmony-shadow-realm", "--experimental-shadow-realm");
+
   Insert(eop, &PerIsolateOptions::get_per_env_options);
 }
 
diff --git a/src/node_options.h b/src/node_options.h
index 7346fc7441eb3c..915d2a4bdcfab8 100644
--- a/src/node_options.h
+++ b/src/node_options.h
@@ -214,6 +214,7 @@ class PerIsolateOptions : public Options {
   bool track_heap_objects = false;
   bool report_uncaught_exception = false;
   bool report_on_signal = false;
+  bool experimental_shadow_realm = false;
   std::string report_signal = "SIGUSR2";
   inline EnvironmentOptions* get_per_env_options();
   void CheckOptions(std::vector<std::string>* errors) override;
diff --git a/src/node_shadow_realm.cc b/src/node_shadow_realm.cc
new file mode 100644
index 00000000000000..2ccd62edc315d7
--- /dev/null
+++ b/src/node_shadow_realm.cc
@@ -0,0 +1,16 @@
+#include "node_shadow_realm.h"
+
+namespace node {
+namespace shadow_realm {
+using v8::Context;
+using v8::Local;
+using v8::MaybeLocal;
+
+// static
+MaybeLocal<Context> HostCreateShadowRealmContextCallback(
+    Local<Context> initiator_context) {
+  return Context::New(initiator_context->GetIsolate());
+}
+
+}  // namespace shadow_realm
+}  // namespace node
diff --git a/src/node_shadow_realm.h b/src/node_shadow_realm.h
new file mode 100644
index 00000000000000..a10fc425661f56
--- /dev/null
+++ b/src/node_shadow_realm.h
@@ -0,0 +1,19 @@
+#ifndef SRC_NODE_SHADOW_REALM_H_
+#define SRC_NODE_SHADOW_REALM_H_
+
+#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
+
+#include "v8.h"
+
+namespace node {
+namespace shadow_realm {
+
+v8::MaybeLocal<v8::Context> HostCreateShadowRealmContextCallback(
+    v8::Local<v8::Context> initiator_context);
+
+}  // namespace shadow_realm
+}  // namespace node
+
+#endif  // defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
+
+#endif  // SRC_NODE_SHADOW_REALM_H_
diff --git a/test/parallel/test-shadow-realm.js b/test/parallel/test-shadow-realm.js
new file mode 100644
index 00000000000000..0b20265537fb5c
--- /dev/null
+++ b/test/parallel/test-shadow-realm.js
@@ -0,0 +1,12 @@
+// Flags: --experimental-shadow-realm
+'use strict';
+
+require('../common');
+const assert = require('assert');
+
+// Validates we can construct ShadowRealm successfully.
+const shadowRealm = new ShadowRealm();
+
+const getter = shadowRealm.evaluate('globalThis.realmValue = "inner"; () => globalThis.realmValue;');
+assert.strictEqual(getter(), 'inner');
+assert.strictEqual('realmValue' in globalThis, false);