From d7b13abbf87e0a0510fc12a1cd6dec88f67b3b8b Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Tue, 28 Apr 2020 18:12:43 +0200 Subject: [PATCH] test: skip memory usage tests when ASAN is enabled Running tests with an ASAN build leads to increased memory usage, rendering the memory usage assumptions in the test invalid. Refs: https://github.com/nodejs/node/pull/32776#issuecomment-620407014 PR-URL: https://github.com/nodejs/node/pull/33129 Reviewed-By: James M Snell Reviewed-By: Colin Ihrig Reviewed-By: Jiawen Geng Reviewed-By: Benjamin Gruenbaum Reviewed-By: Matheus Marchini Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca --- test/parallel/test-crypto-dh-leak.js | 2 ++ test/sequential/test-net-bytes-per-incoming-chunk-overhead.js | 3 +++ 2 files changed, 5 insertions(+) diff --git a/test/parallel/test-crypto-dh-leak.js b/test/parallel/test-crypto-dh-leak.js index 9ba8d29e155dc6..65486dbd80cb64 100644 --- a/test/parallel/test-crypto-dh-leak.js +++ b/test/parallel/test-crypto-dh-leak.js @@ -4,6 +4,8 @@ const common = require('../common'); if (!common.hasCrypto) common.skip('missing crypto'); +if (process.config.variables.asan) + common.skip('ASAN messes with memory measurements'); const assert = require('assert'); const crypto = require('crypto'); diff --git a/test/sequential/test-net-bytes-per-incoming-chunk-overhead.js b/test/sequential/test-net-bytes-per-incoming-chunk-overhead.js index c2275b570ca08e..6eec8cc3c6d6c8 100644 --- a/test/sequential/test-net-bytes-per-incoming-chunk-overhead.js +++ b/test/sequential/test-net-bytes-per-incoming-chunk-overhead.js @@ -2,6 +2,9 @@ 'use strict'; const common = require('../common'); +if (process.config.variables.asan) + common.skip('ASAN messes with memory measurements'); + const assert = require('assert'); const net = require('net');