From d8ce990ce63ba781bbce3c2d0dbf5be79e1f31f8 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Fri, 6 Jan 2023 05:53:47 +0100 Subject: [PATCH] meta: update comment in `CODEOWNERS` to better reflect current policy We do not enforce signing off by any code owners when landing PRs. PR-URL: https://github.com/nodejs/node/pull/45944 Reviewed-By: Luigi Pinca Reviewed-By: Darshan Sen Reviewed-By: Joyee Cheung Reviewed-By: Geoffrey Booth Reviewed-By: Rich Trott Reviewed-By: Chengzhong Wu Reviewed-By: Michael Dawson Reviewed-By: Beth Griggs Reviewed-By: Danielle Adams --- .github/CODEOWNERS | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 9df30710255974..aa74d154f1114a 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,9 +1,12 @@ # Node.js Project Codeowners -# 1. Codeowners must always be teams, never individuals -# 2. Each codeowner team should contain at least one TSC member -# 3. PRs touching any code with a codeowner must be signed off by at least one -# person on the code owner team. +# This file does not define any requirements for landing PRs. +# Its purpose is to allow automation of courtesy pings to the +# relevant team(s) when any of the paths listed here are modified. +# Criteria for landing PRs are defined in +# https://github.com/nodejs/node/blob/main/doc/contributing/collaborator-guide.md#code-reviews. +# +# Codeowners must always be teams, never individuals. # tsc