From d8f8719415211ac98ddec4f1aecd406a6cdb89d1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Mon, 19 Oct 2020 08:20:06 +0200 Subject: [PATCH] build: do not pass mode option to test-v8 command It was removed upstream and is now inferred from the build config. PR-URL: https://github.com/nodejs/node/pull/35705 Reviewed-By: Richard Lau Reviewed-By: Jiawen Geng Reviewed-By: Beth Griggs Reviewed-By: Daijiro Wachi Reviewed-By: Rich Trott PR-URL: https://github.com/nodejs/node/pull/38275 Reviewed-By: Matteo Collina Reviewed-By: Shelley Vohr --- Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 09018aac3095e7..d13d843bc49c8e 100644 --- a/Makefile +++ b/Makefile @@ -648,8 +648,7 @@ test-with-async-hooks: ifneq ("","$(wildcard deps/v8/tools/run-tests.py)") # Related CI job: node-test-commit-v8-linux test-v8: v8 ## Runs the V8 test suite on deps/v8. - deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \ - --mode=$(BUILDTYPE_LOWER) $(V8_TEST_OPTIONS) \ + deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) $(V8_TEST_OPTIONS) \ mjsunit cctest debugger inspector message preparser \ $(TAP_V8) $(info Testing hash seed)