From de250c136cf76fdb120b881316ebb08347565e48 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Fri, 3 Jul 2020 15:19:28 +0200 Subject: [PATCH] build: recommend Python 3.8 to build on Windows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/34182 Reviewed-By: Christian Clauss Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen Reviewed-By: James M Snell Reviewed-By: Jiawen Geng --- .github/workflows/build-tarball.yml | 6 +++--- BUILDING.md | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-tarball.yml b/.github/workflows/build-tarball.yml index 3a3138a677b1d6..f17fabd84056bc 100644 --- a/.github/workflows/build-tarball.yml +++ b/.github/workflows/build-tarball.yml @@ -72,10 +72,10 @@ jobs: run: | git config --global core.autocrlf true - uses: actions/checkout@v2 - - name: Set up Python 2.7 - uses: actions/setup-python@v1 + - name: Set up Python 3.8 + uses: actions/setup-python@v2 with: - python-version: 2.7 + python-version: 3.8 - name: Environment Information run: npx envinfo - name: Download tarball diff --git a/BUILDING.md b/BUILDING.md index 0a8f24c694222e..9c8b868e6323d5 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -526,7 +526,7 @@ to run it again before invoking `make -j4`. ##### Option 1: Manual install -* [Python 2.7](https://www.python.org/downloads/) +* [Python 3.8](https://www.python.org/downloads/) * The "Desktop development with C++" workload from [Visual Studio 2017 or 2019](https://visualstudio.microsoft.com/downloads/) or the "Visual C++ build tools" workload from the