Navigation Menu

Skip to content

Commit

Permalink
meta: add N-API to codeowners coverage
Browse files Browse the repository at this point in the history
We have this guidance for contributing to N-API:
https://github.com/nodejs/node/blob/master/doc/guides/adding-new-napi-api.md

It makes sense to have one of the N-API team sign off on commits
that changes N-API

Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

PR-URL: #34039
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
mhdawson authored and MylesBorins committed Jul 16, 2020
1 parent 8dd8b1a commit de58eb6
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Expand Up @@ -74,3 +74,10 @@
# ./lib/internal/modules/* @nodejs/modules
# ./lib/internal/bootstrap/loaders.js @nodejs/modules
# ./src/module_wrap* @nodejs/modules @nodejs/vm

# N-API

# /src/node_api* @nodejs/n-api
# /src/js_native_api* @nodejs/n-api
# /doc/guides/adding-new-napi-api.md @nodejs/n-api
# /doc/api/n-api.md @nodejs/n-api

0 comments on commit de58eb6

Please sign in to comment.