From e0ff0283901439e229e93f3db540634e76538dc6 Mon Sep 17 00:00:00 2001 From: Myles Borins Date: Thu, 13 Feb 2020 15:03:18 -0800 Subject: [PATCH] 2020-02-14, Version 12.16.1 'Erbium' (LTS) Notable changes: Node.js 12.16.0 included 3 regressions that are being fixed in this release Accidental Unflagging of Self Resolving Modules: 12.16.0 included a large update to the ESM implementation. One of the new features, Self Referential Modules, was accidentally released without requiring the `--experimental-modules` flag. This release is being made to appropriately flag the feature. Isolate Disposal Order Change Introduced WASM Assertion: A change in the order of Isolate Disposal created an assertion error in WASM usage in V8. This was not present on 13.x or higher as they use a newer version of V8. The change was reverted. A regression test and fix are being worked on and will likely be included in a future 12.x release Use Largepages Runtime Option Introduced Linking Failure: A Semver-Minor change to introduce `--use-largepages` as a runtime option introduced a linking failure. This had been fixed in master but regressed as the fix has not yet gone out in a Current release. The feature has been reverted, but will be able to re-land with a fix in a future Semver-Minor release. Async Hooks was Causing an Exception When Handling Errors: Changes in async hooks internals introduced a case where an internal api call could be called with undefined causing a process to crash. The change to async hooks was reverted. A regression test and fix has been proposed and the change could re land in a future Semver-Patch release if the regression is reliably fixed. PR-URL: https://github.com/nodejs/node/pull/31781 --- CHANGELOG.md | 3 ++- doc/changelogs/CHANGELOG_V12.md | 45 +++++++++++++++++++++++++++++++++ src/node_version.h | 2 +- 3 files changed, 48 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2d5eac43a880e4..72ddc64c563cde 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -28,7 +28,8 @@ release. -12.16.0
+12.16.1
+12.16.0
12.15.0
12.14.1
12.14.0
diff --git a/doc/changelogs/CHANGELOG_V12.md b/doc/changelogs/CHANGELOG_V12.md index 231a9a33a58429..97d474ddd5a28d 100644 --- a/doc/changelogs/CHANGELOG_V12.md +++ b/doc/changelogs/CHANGELOG_V12.md @@ -10,6 +10,7 @@ +12.16.1
12.16.0
12.15.0
12.14.1
@@ -53,6 +54,50 @@ * [io.js](CHANGELOG_IOJS.md) * [Archive](CHANGELOG_ARCHIVE.md) + +## 2020-02-14, Version 12.16.1 'Erbium' (LTS), @MylesBorins + +### Notable changes + +Node.js 12.16.0 included 4 regressions that are being fixed in this release + +**Accidental Unflagging of Self Resolving Modules**: + +12.16.0 included a large update to the ESM implementation. One of the new features, +Self Referential Modules, was accidentally released without requiring the `--experimental-modules` +flag. This release is being made to appropriately flag the feature. + +**Isolate Disposal Order Change Introduced WASM Assertion**: + +A change in the order of Isolate Disposal created an assertion error in WASM usage in V8. This was +not present on 13.x or higher as they use a newer version of V8. The change was reverted. A regression +test and fix are being worked on and will likely be included in a future 12.x release + +**Use Largepages Runtime Option Introduced Linking Failure**: + +A Semver-Minor change to introduce `--use-largepages` as a runtime option +introduced a linking failure. This had been fixed in master but regressed as the fix has not yet gone out +in a Current release. The feature has been reverted, but will be able to reland with a fix in a future +Semver-Minor release. + +**Async Hooks was Causing an Exception When Handling Errors**: + +Changes in async hooks internals introduced a case where an internal api call could be called with undefined +causing a process to crash. The change to async hooks was reverted. A regression test and fix has been proposed +and the change could re land in a future Semver-Patch release if the regression is reliably fixed. + +### Commits + +* [[`e07237ce9f`](https://github.com/nodejs/node/commit/e07237ce9f)] - ***Revert*** "**async_hooks**: ensure proper handling in runInAsyncScope" (Myles Borins) +* [[`b6b1d89034`](https://github.com/nodejs/node/commit/b6b1d89034)] - ***Revert*** "**build**: re-introduce --use-largepages as no-op" (Myles Borins) [#31782](https://github.com/nodejs/node/pull/31782) +* [[`c87baba2df`](https://github.com/nodejs/node/commit/c87baba2df)] - ***Revert*** "**build**: switch realpath to pwd" (Myles Borins) [#31782](https://github.com/nodejs/node/pull/31782) +* [[`b6e266d707`](https://github.com/nodejs/node/commit/b6e266d707)] - ***Revert*** "**build**: warn upon --use-largepages config option" (Myles Borins) [#31782](https://github.com/nodejs/node/pull/31782) +* [[`f0b2d875d9`](https://github.com/nodejs/node/commit/f0b2d875d9)] - **module**: 12.x self resolve flag as experimental modules (Guy Bedford) [#31757](https://github.com/nodejs/node/pull/31757) +* [[`2ea5c914a3`](https://github.com/nodejs/node/commit/2ea5c914a3)] - ***Revert*** "**src**: make --use-largepages a runtime option" (Myles Borins) [#31782](https://github.com/nodejs/node/pull/31782) +* [[`70639a51c5`](https://github.com/nodejs/node/commit/70639a51c5)] - ***Revert*** "**src**: make large\_pages node.cc include conditional" (Myles Borins) [#31782](https://github.com/nodejs/node/pull/31782) +* [[`d1301843ce`](https://github.com/nodejs/node/commit/d1301843ce)] - ***Revert*** "**src**: unregister Isolate with platform before disposing" (Myles Borins) [#31782](https://github.com/nodejs/node/pull/31782) +* [[`7a5954ef26`](https://github.com/nodejs/node/commit/7a5954ef26)] - **src**: fix -Winconsistent-missing-override warning (Colin Ihrig) [#30549](https://github.com/nodejs/node/pull/30549) + ## 2020-02-11, Version 12.16.0 'Erbium' (LTS), @targos diff --git a/src/node_version.h b/src/node_version.h index b50e2cadb6d6ba..88831ab19d7201 100644 --- a/src/node_version.h +++ b/src/node_version.h @@ -29,7 +29,7 @@ #define NODE_VERSION_IS_LTS 1 #define NODE_VERSION_LTS_CODENAME "Erbium" -#define NODE_VERSION_IS_RELEASE 0 +#define NODE_VERSION_IS_RELEASE 1 #ifndef NODE_STRINGIFY #define NODE_STRINGIFY(n) NODE_STRINGIFY_HELPER(n)