From e1e059a698b6d42edf66d2fc779aa14fd4f7e403 Mon Sep 17 00:00:00 2001
From: Michael Dawson <mdawson@devrus.com>
Date: Tue, 18 Jan 2022 10:41:59 -0500
Subject: [PATCH] perf_hooks: remove useless calls in Histogram

Coverity reported some calls that had no effect,
remove them

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/41579
Reviewed-By: Yash Ladha <yash@yashladha.in>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
---
 src/histogram.cc | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/src/histogram.cc b/src/histogram.cc
index 87641a4a3691c7..63fa52a57df157 100644
--- a/src/histogram.cc
+++ b/src/histogram.cc
@@ -159,10 +159,10 @@ void HistogramBase::GetPercentiles(const FunctionCallbackInfo<Value>& args) {
   CHECK(args[0]->IsMap());
   Local<Map> map = args[0].As<Map>();
   (*histogram)->Percentiles([map, env](double key, int64_t value) {
-    map->Set(
-        env->context(),
-        Number::New(env->isolate(), key),
-        Number::New(env->isolate(), static_cast<double>(value))).IsEmpty();
+    USE(map->Set(
+          env->context(),
+          Number::New(env->isolate(), key),
+          Number::New(env->isolate(), static_cast<double>(value))));
   });
 }
 
@@ -174,10 +174,10 @@ void HistogramBase::GetPercentilesBigInt(
   CHECK(args[0]->IsMap());
   Local<Map> map = args[0].As<Map>();
   (*histogram)->Percentiles([map, env](double key, int64_t value) {
-    map->Set(
-        env->context(),
-        Number::New(env->isolate(), key),
-        BigInt::New(env->isolate(), value)).IsEmpty();
+    USE(map->Set(
+          env->context(),
+          Number::New(env->isolate(), key),
+          BigInt::New(env->isolate(), value)));
   });
 }
 
@@ -589,10 +589,10 @@ void IntervalHistogram::GetPercentiles(
   CHECK(args[0]->IsMap());
   Local<Map> map = args[0].As<Map>();
   (*histogram)->Percentiles([map, env](double key, int64_t value) {
-    map->Set(
-        env->context(),
-        Number::New(env->isolate(), key),
-        Number::New(env->isolate(), static_cast<double>(value))).IsEmpty();
+    USE(map->Set(
+          env->context(),
+          Number::New(env->isolate(), key),
+          Number::New(env->isolate(), static_cast<double>(value))));
   });
 }
 
@@ -604,10 +604,10 @@ void IntervalHistogram::GetPercentilesBigInt(
   CHECK(args[0]->IsMap());
   Local<Map> map = args[0].As<Map>();
   (*histogram)->Percentiles([map, env](double key, int64_t value) {
-    map->Set(
-        env->context(),
-        Number::New(env->isolate(), key),
-        BigInt::New(env->isolate(), value)).IsEmpty();
+    USE(map->Set(
+          env->context(),
+          Number::New(env->isolate(), key),
+          BigInt::New(env->isolate(), value)));
   });
 }