From e5826ab1c2e8bec637e3d54f967cdac2072914ad Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 18 Jun 2021 18:52:37 -0700 Subject: [PATCH] debugger: remove final lint exceptions in inspect_repl.js MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Adding a return when it's not really a getter is kind of misleading, but so is using a getter for something that doesn't return anything, so ¯\_(ツ)_/¯. PR-URL: https://github.com/nodejs/node/pull/39078 Reviewed-By: Antoine du Hamel --- lib/internal/debugger/inspect_repl.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/internal/debugger/inspect_repl.js b/lib/internal/debugger/inspect_repl.js index 5393cb32718300..a93a8dfecf2720 100644 --- a/lib/internal/debugger/inspect_repl.js +++ b/lib/internal/debugger/inspect_repl.js @@ -1,6 +1,3 @@ -// TODO(trott): enable ESLint -/* eslint-disable getter-return */ - 'use strict'; const { @@ -899,7 +896,7 @@ function createRepl(inspector) { copyOwnProperties(context, { get help() { - print(HELP); + return print(HELP); }, get run() { @@ -1078,7 +1075,7 @@ function createRepl(inspector) { repl.setPrompt('> '); print('Press Ctrl+C to leave debug repl'); - repl.displayPrompt(); + return repl.displayPrompt(); }, get version() {