From e668376b5b4f663f5c916ddfbf1625fae4e4eb9f Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Fri, 15 May 2020 09:12:46 +0200 Subject: [PATCH] src: remove unused misc variable This commit removes the unused 'misc' variable from one of the NodeMainInstance constructors. Another option could be to add a default argument to SetIsolateMiscHandlers but I'd like to hear what others think about that first. PR-URL: https://github.com/nodejs/node/pull/33417 Reviewed-By: Anna Henningsen Reviewed-By: James M Snell --- src/node_main_instance.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/node_main_instance.cc b/src/node_main_instance.cc index 998cf260de2a62..8e3ea81dfc8494 100644 --- a/src/node_main_instance.cc +++ b/src/node_main_instance.cc @@ -39,8 +39,7 @@ NodeMainInstance::NodeMainInstance(Isolate* isolate, isolate_data_ = std::make_unique(isolate_, event_loop, platform, nullptr); - IsolateSettings misc; - SetIsolateMiscHandlers(isolate_, misc); + SetIsolateMiscHandlers(isolate_, {}); } std::unique_ptr NodeMainInstance::Create(