Skip to content

Commit

Permalink
src: fix finalization crash
Browse files Browse the repository at this point in the history
PR-URL: #38250
Backport-PR-URL: #42512
Fixes: #38040
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
jasnell authored and richardlau committed Mar 30, 2022
1 parent 81b4dc8 commit e707514
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/js_native_api_v8.cc
Expand Up @@ -379,6 +379,9 @@ class Reference : public RefBase {

protected:
inline void Finalize(bool is_env_teardown = false) override {
if (is_env_teardown) env_teardown_finalize_started_ = true;
if (!is_env_teardown && env_teardown_finalize_started_) return;

// During env teardown, `~napi_env()` alone is responsible for finalizing.
// Thus, we don't want any stray gc passes to trigger a second call to
// `RefBase::Finalize()`. ClearWeak will ensure that even if the
Expand Down Expand Up @@ -467,6 +470,7 @@ class Reference : public RefBase {
reference->Finalize();
}

bool env_teardown_finalize_started_ = false;
v8impl::Persistent<v8::Value> _persistent;
SecondPassCallParameterRef* _secondPassParameter;
};
Expand Down

0 comments on commit e707514

Please sign in to comment.