From e72b5ec2d057e6f1cb375bc46aa0955616da446b Mon Sep 17 00:00:00 2001 From: RafaelGSS Date: Fri, 14 Oct 2022 15:08:37 -0300 Subject: [PATCH] doc: improve the workflow to test release binaries --- doc/contributing/releases.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/doc/contributing/releases.md b/doc/contributing/releases.md index a1045476d18399..f5dd65a4332d9c 100644 --- a/doc/contributing/releases.md +++ b/doc/contributing/releases.md @@ -603,12 +603,18 @@ the build before moving forward. Use the following list as a baseline: must be in the expected updated version) * npm version (check it matches what we expect) * Run the test suite against the built binaries (optional) + * Remember to use the proposal branch + * Run `make build-addons` before running the tests + * Remove `config.gypi` file ```console ./tools/test.py --shell ~/Downloads/node-v18.5.0-linux-x64/bin/node ``` -There may be test issues if the branch used to test does not match the Node.js binary. +There may be test issues if the binary used to test does not match to +the expected variables. +This usually happens on `test-child-process-stdio-overlapped.js` and +`test-process-config` tests ### 11. Tag and sign the release commit