Skip to content

Commit e76ac1d

Browse files
Trottcodebytere
authored andcommittedFeb 27, 2020
test: remove common.PORT from test-net-throttle
Switch test-net-throttle from common.PORT to a port assigned by the operating system. PR-URL: #31749 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 724bf31 commit e76ac1d

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed
 

‎test/pummel/test-net-throttle.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
// USE OR OTHER DEALINGS IN THE SOFTWARE.
2121

2222
'use strict';
23-
const common = require('../common');
23+
require('../common');
2424
const assert = require('assert');
2525
const net = require('net');
2626

@@ -32,8 +32,6 @@ let npauses = 0;
3232
console.log('build big string');
3333
const body = 'C'.repeat(N);
3434

35-
console.log(`start server on port ${common.PORT}`);
36-
3735
const server = net.createServer((connection) => {
3836
connection.write(body.slice(0, part_N));
3937
connection.write(body.slice(part_N, 2 * part_N));
@@ -44,9 +42,11 @@ const server = net.createServer((connection) => {
4442
connection.end();
4543
});
4644

47-
server.listen(common.PORT, () => {
45+
server.listen(0, () => {
46+
const port = server.address().port;
47+
console.log(`server started on port ${port}`);
4848
let paused = false;
49-
const client = net.createConnection(common.PORT);
49+
const client = net.createConnection(port);
5050
client.setEncoding('ascii');
5151
client.on('data', (d) => {
5252
chars_recved += d.length;

0 commit comments

Comments
 (0)
Please sign in to comment.