From e9bda6618d351ecc7c94c78dbe4aecaecd99e599 Mon Sep 17 00:00:00 2001 From: cjihrig Date: Thu, 5 Dec 2019 10:12:22 -0500 Subject: [PATCH] src: use checked allocations in WASI::New() PR-URL: https://github.com/nodejs/node/pull/30809 Refs: https://github.com/nodejs/node/issues/30257 Reviewed-By: Anna Henningsen Reviewed-By: Jiawen Geng Reviewed-By: Rich Trott Reviewed-By: David Carlier --- src/node_wasi.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/node_wasi.cc b/src/node_wasi.cc index 4d7f0e53f61b14..a9b5dae9d6ceca 100644 --- a/src/node_wasi.cc +++ b/src/node_wasi.cc @@ -133,7 +133,7 @@ void WASI::New(const FunctionCallbackInfo& args) { Local preopens = args[2].As(); CHECK_EQ(preopens->Length() % 2, 0); options.preopenc = preopens->Length() / 2; - options.preopens = UncheckedCalloc(options.preopenc); + options.preopens = Calloc(options.preopenc); int index = 0; for (uint32_t i = 0; i < preopens->Length(); i += 2) { auto mapped = preopens->Get(context, i).ToLocalChecked(); @@ -143,7 +143,9 @@ void WASI::New(const FunctionCallbackInfo& args) { node::Utf8Value mapped_path(env->isolate(), mapped); node::Utf8Value real_path(env->isolate(), real); options.preopens[index].mapped_path = strdup(*mapped_path); + CHECK_NOT_NULL(options.preopens[index].mapped_path); options.preopens[index].real_path = strdup(*real_path); + CHECK_NOT_NULL(options.preopens[index].real_path); index++; }