Skip to content

Commit ea1fda6

Browse files
davis.okoth@kemsa.co.keBethGriggs
davis.okoth@kemsa.co.ke
authored andcommittedDec 4, 2018
test: remove third param from assert.strictEqual
Removing third argument in calls to assert.strictEqual() so that the values of the first two arguments are shown instead as this is more useful for debugging. Refs: https://nodejs.org/api/assert.html#assert_assert_strictequal_actual_expected_message PR-URL: #19536 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent c3ecf05 commit ea1fda6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed
 

‎test/parallel/test-fs-mkdir-rmdir.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ fs.mkdir(d, 0o666, common.mustCall(function(err) {
3131
fs.mkdir(d, 0o666, common.mustCall(function(err) {
3232
assert.ok(err, 'got no error');
3333
assert.ok(/^EEXIST/.test(err.message), 'got no EEXIST message');
34-
assert.strictEqual(err.code, 'EEXIST', 'got no EEXIST code');
35-
assert.strictEqual(err.path, d, 'got no proper path for EEXIST');
34+
assert.strictEqual(err.code, 'EEXIST');
35+
assert.strictEqual(err.path, d);
3636

3737
fs.rmdir(d, assert.ifError);
3838
}));

0 commit comments

Comments
 (0)
Please sign in to comment.