Skip to content

Commit ecadd63

Browse files
committedApr 17, 2024
deps: V8: remove references to non-existent flags
#49703 cherry-picked a commit from upstream V8 which references some maglev-related flags that are not present in the version of V8 in Node.js 20. PR-URL: #52256 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
1 parent b9eb003 commit ecadd63

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed
 

‎common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.19',
39+
'v8_embedder_string': '-node.20',
4040

4141
##### V8 defaults for Node.js #####
4242

‎deps/v8/src/flags/flags.cc

-4
Original file line numberDiff line numberDiff line change
@@ -586,10 +586,6 @@ uint32_t ComputeFlagListHash() {
586586
// The following flags are implied by --predictable (some negated).
587587
if (flag.PointsTo(&v8_flags.concurrent_sparkplug) ||
588588
flag.PointsTo(&v8_flags.concurrent_recompilation) ||
589-
#ifdef V8_ENABLE_MAGLEV
590-
flag.PointsTo(&v8_flags.maglev_deopt_data_on_background) ||
591-
flag.PointsTo(&v8_flags.maglev_build_code_on_background) ||
592-
#endif
593589
flag.PointsTo(&v8_flags.parallel_scavenge) ||
594590
flag.PointsTo(&v8_flags.concurrent_marking) ||
595591
flag.PointsTo(&v8_flags.concurrent_array_buffer_sweeping) ||

0 commit comments

Comments
 (0)
Please sign in to comment.