From ee3c6a4dc5eed0dbe7420a46e3e6fbc49afb2cb7 Mon Sep 17 00:00:00 2001
From: pete3249 <63552971+pete3249@users.noreply.github.com>
Date: Thu, 29 Sep 2022 22:46:02 -0400
Subject: [PATCH] test: use async/await in test-debugger-exceptions

PR-URL: https://github.com/nodejs/node/pull/44690
Reviewed-By: Rich Trott <rtrott@gmail.com>
---
 test/sequential/test-debugger-exceptions.js | 73 +++++++++------------
 1 file changed, 30 insertions(+), 43 deletions(-)

diff --git a/test/sequential/test-debugger-exceptions.js b/test/sequential/test-debugger-exceptions.js
index f20f35d4808a47..3f75161a6b6e3d 100644
--- a/test/sequential/test-debugger-exceptions.js
+++ b/test/sequential/test-debugger-exceptions.js
@@ -15,57 +15,44 @@ const path = require('path');
   const script = path.relative(process.cwd(), scriptFullPath);
   const cli = startCLI([script]);
 
-  function onFatal(error) {
-    cli.quit();
-    throw error;
-  }
-
-  cli.waitForInitialBreak()
-    .then(() => cli.waitForPrompt())
-    .then(() => {
+  (async () => {
+    try {
+      await cli.waitForInitialBreak();
+      await cli.waitForPrompt();
+      await cli.waitForPrompt();
       assert.deepStrictEqual(cli.breakInfo, { filename: script, line: 1 });
-    })
-    // Making sure it will die by default:
-    .then(() => cli.command('c'))
-    .then(() => cli.waitFor(/disconnect/))
 
-    // Next run: With `breakOnException` it pauses in both places.
-    .then(() => cli.stepCommand('r'))
-    .then(() => cli.waitForInitialBreak())
-    .then(() => {
+      // Making sure it will die by default:
+      await cli.command('c');
+      await cli.waitFor(/disconnect/);
+
+      // Next run: With `breakOnException` it pauses in both places.
+      await cli.stepCommand('r');
+      await cli.waitForInitialBreak();
       assert.deepStrictEqual(cli.breakInfo, { filename: script, line: 1 });
-    })
-    .then(() => cli.command('breakOnException'))
-    .then(() => cli.stepCommand('c'))
-    .then(() => {
+      await cli.command('breakOnException');
+      await cli.stepCommand('c');
       assert.ok(cli.output.includes(`exception in ${script}:3`));
-    })
-    .then(() => cli.stepCommand('c'))
-    .then(() => {
+      await cli.stepCommand('c');
       assert.ok(cli.output.includes(`exception in ${script}:9`));
-    })
 
-    // Next run: With `breakOnUncaught` it only pauses on the 2nd exception.
-    .then(() => cli.command('breakOnUncaught'))
-    .then(() => cli.stepCommand('r')) // Also, the setting survives the restart.
-    .then(() => cli.waitForInitialBreak())
-    .then(() => {
+      // Next run: With `breakOnUncaught` it only pauses on the 2nd exception.
+      await cli.command('breakOnUncaught');
+      await cli.stepCommand('r'); // Also, the setting survives the restart.
+      await cli.waitForInitialBreak();
       assert.deepStrictEqual(cli.breakInfo, { filename: script, line: 1 });
-    })
-    .then(() => cli.stepCommand('c'))
-    .then(() => {
+      await cli.stepCommand('c');
       assert.ok(cli.output.includes(`exception in ${script}:9`));
-    })
 
-    // Next run: Back to the initial state! It should die again.
-    .then(() => cli.command('breakOnNone'))
-    .then(() => cli.stepCommand('r'))
-    .then(() => cli.waitForInitialBreak())
-    .then(() => {
+      // Next run: Back to the initial state! It should die again.
+      await cli.command('breakOnNone');
+      await cli.stepCommand('r');
+      await cli.waitForInitialBreak();
       assert.deepStrictEqual(cli.breakInfo, { filename: script, line: 1 });
-    })
-    .then(() => cli.command('c'))
-    .then(() => cli.waitFor(/disconnect/))
-    .then(() => cli.quit())
-    .then(null, onFatal);
+      await cli.command('c');
+      await cli.waitFor(/disconnect/);
+    } finally {
+      cli.quit();
+    }
+  })().then(common.mustCall());
 }