From ee85eb9f8a311e955116ecfd9c6c336351336116 Mon Sep 17 00:00:00 2001 From: Simen Bekkhus Date: Sun, 11 Oct 2020 13:52:17 +0200 Subject: [PATCH] doc: importModuleDynamically gets Script, not Module PR-URL: https://github.com/nodejs/node/pull/35593 Reviewed-By: Gus Caplan Reviewed-By: Rich Trott Reviewed-By: Benjamin Gruenbaum --- doc/api/vm.md | 8 ++++---- tools/doc/type-parser.js | 1 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/doc/api/vm.md b/doc/api/vm.md index ce5ff95f72bccc..caf300e9fd7e2c 100644 --- a/doc/api/vm.md +++ b/doc/api/vm.md @@ -90,7 +90,7 @@ changes: This option is part of the experimental modules API, and should not be considered stable. * `specifier` {string} specifier passed to `import()` - * `module` {vm.Module} + * `script` {vm.Script} * Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is recommended in order to take advantage of error tracking, and to avoid issues with namespaces that contain `then` function exports. @@ -984,7 +984,7 @@ changes: This option is part of the experimental modules API, and should not be considered stable. * `specifier` {string} specifier passed to `import()` - * `module` {vm.Module} + * `script` {vm.Script} * Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is recommended in order to take advantage of error tracking, and to avoid issues with namespaces that contain `then` function exports. @@ -1082,7 +1082,7 @@ changes: This option is part of the experimental modules API, and should not be considered stable. * `specifier` {string} specifier passed to `import()` - * `module` {vm.Module} + * `script` {vm.Script} * Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is recommended in order to take advantage of error tracking, and to avoid issues with namespaces that contain `then` function exports. @@ -1161,7 +1161,7 @@ changes: This option is part of the experimental modules API, and should not be considered stable. * `specifier` {string} specifier passed to `import()` - * `module` {vm.Module} + * `script` {vm.Script} * Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is recommended in order to take advantage of error tracking, and to avoid issues with namespaces that contain `then` function exports. diff --git a/tools/doc/type-parser.js b/tools/doc/type-parser.js index 8a2fc18206b412..9a96d857a25177 100644 --- a/tools/doc/type-parser.js +++ b/tools/doc/type-parser.js @@ -206,6 +206,7 @@ const customTypesMap = { 'URLSearchParams': 'url.html#url_class_urlsearchparams', 'vm.Module': 'vm.html#vm_class_vm_module', + 'vm.Script': 'vm.html#vm_class_vm_script', 'vm.SourceTextModule': 'vm.html#vm_class_vm_sourcetextmodule', 'MessagePort': 'worker_threads.html#worker_threads_class_messageport',