From ef72490cde1d8a735089c30219e293e5cc59eca5 Mon Sep 17 00:00:00 2001
From: Nitzan Uziely <linkgoron@gmail.com>
Date: Sun, 18 Apr 2021 22:40:59 +0300
Subject: [PATCH] fs: allow no-params fsPromises fileHandle read

allow no-params read for fsPromises fileHandle read

PR-URL: https://github.com/nodejs/node/pull/38287
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
---
 doc/api/fs.md                                      | 2 +-
 lib/internal/fs/promises.js                        | 3 +++
 test/parallel/test-fs-promises-file-handle-read.js | 8 ++++++++
 3 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/doc/api/fs.md b/doc/api/fs.md
index e5c04d97541aa2..8c12ce0bdbd9ca 100644
--- a/doc/api/fs.md
+++ b/doc/api/fs.md
@@ -275,7 +275,7 @@ Reads data from the file and stores that in the given buffer.
 If the file is not modified concurrently, the end-of-file is reached when the
 number of bytes read is zero.
 
-#### `filehandle.read(options)`
+#### `filehandle.read([options])`
 <!-- YAML
 added:
  - v13.11.0
diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js
index 7fc15713ed5614..b9b705caec2899 100644
--- a/lib/internal/fs/promises.js
+++ b/lib/internal/fs/promises.js
@@ -388,6 +388,9 @@ async function open(path, flags, mode) {
 async function read(handle, bufferOrOptions, offset, length, position) {
   let buffer = bufferOrOptions;
   if (!isArrayBufferView(buffer)) {
+    if (bufferOrOptions === undefined) {
+      bufferOrOptions = {};
+    }
     if (bufferOrOptions.buffer) {
       buffer = bufferOrOptions.buffer;
       validateBuffer(buffer);
diff --git a/test/parallel/test-fs-promises-file-handle-read.js b/test/parallel/test-fs-promises-file-handle-read.js
index 30113c42a8d9d4..74383a02e42fd9 100644
--- a/test/parallel/test-fs-promises-file-handle-read.js
+++ b/test/parallel/test-fs-promises-file-handle-read.js
@@ -60,6 +60,13 @@ async function validateLargeRead() {
   assert.strictEqual(readHandle.bytesRead, 0);
 }
 
+async function validateReadNoParams() {
+  const filePath = fixtures.path('x.txt');
+  const fileHandle = await open(filePath, 'r');
+  // Should not throw
+  await fileHandle.read();
+}
+
 let useConf = false;
 
 (async function() {
@@ -72,4 +79,5 @@ let useConf = false;
           .then(validateLargeRead)
           .then(common.mustCall());
   }
+  await validateReadNoParams();
 })().then(common.mustCall());