Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
deps: V8: cherry-pick 717543bbf0ef
Original commit message:

    [zone]: fix build on msvc in wasm module

    Fix: nodejs/node-v8#172
    Change-Id: Ibdbee76470ec8a4c20af7650dc5fac4602873430
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2414688
    Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70109}

Refs: v8/v8@717543b

PR-URL: #35415
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
  • Loading branch information
targos committed Oct 18, 2020
1 parent b006fa8 commit efee834
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion common.gypi
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.12',
'v8_embedder_string': '-node.13',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 2 additions & 0 deletions deps/v8/src/wasm/wasm-module-builder.h
Expand Up @@ -361,6 +361,8 @@ class V8_EXPORT_PRIVATE WasmModuleBuilder : public ZoneObject {
// Indirect functions must be allocated before adding extra tables.
bool allocating_indirect_functions_allowed_ = true;
#endif

DISALLOW_COPY_AND_ASSIGN(WasmModuleBuilder);
};

inline FunctionSig* WasmFunctionBuilder::signature() {
Expand Down

0 comments on commit efee834

Please sign in to comment.