Skip to content

Commit f3c6feb

Browse files
tniessenMylesBorins
authored andcommittedMar 30, 2018
test: update references to archived repository
Backport-PR-URL: #19120 PR-URL: #17924 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 269c2f3 commit f3c6feb

14 files changed

+42
-26
lines changed
 

‎test/parallel/test-assert.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -522,7 +522,7 @@ testAssertionMessage({a: undefined, b: null}, '{ a: undefined, b: null }');
522522
testAssertionMessage({a: NaN, b: Infinity, c: -Infinity},
523523
'{ a: NaN, b: Infinity, c: -Infinity }');
524524

525-
// #2893
525+
// https://github.com/nodejs/node-v0.x-archive/issues/2893
526526
try {
527527
// eslint-disable-next-line no-restricted-syntax
528528
assert.throws(function() {
@@ -534,7 +534,7 @@ try {
534534
}
535535
assert.ok(threw);
536536

537-
// #5292
537+
// https://github.com/nodejs/node-v0.x-archive/issues/5292
538538
try {
539539
assert.strictEqual(1, 2);
540540
} catch (e) {

‎test/parallel/test-buffer-alloc.js

+9-5
Original file line numberDiff line numberDiff line change
@@ -629,7 +629,8 @@ assert.strictEqual('<Buffer 81 a3 66 6f 6f a3 62 61 72>', x.inspect());
629629
}
630630

631631
{
632-
// #1210 Test UTF-8 string includes null character
632+
// https://github.com/nodejs/node-v0.x-archive/pull/1210
633+
// Test UTF-8 string includes null character
633634
let buf = Buffer.from('\0');
634635
assert.strictEqual(buf.length, 1);
635636
buf = Buffer.from('\0\0');
@@ -653,7 +654,8 @@ assert.strictEqual('<Buffer 81 a3 66 6f 6f a3 62 61 72>', x.inspect());
653654
}
654655

655656
{
656-
// #243 Test write() with maxLength
657+
// https://github.com/nodejs/node-v0.x-archive/issues/243
658+
// Test write() with maxLength
657659
const buf = Buffer.allocUnsafe(4);
658660
buf.fill(0xFF);
659661
assert.strictEqual(buf.write('abcd', 1, 2, 'utf8'), 2);
@@ -937,11 +939,13 @@ assert.throws(() => Buffer.allocUnsafe(8).writeFloatLE(0.0, -1), RangeError);
937939
assert.strictEqual(buf.readIntBE(0, 5), -0x0012000000);
938940
}
939941

940-
// Regression test for #5482: should throw but not assert in C++ land.
942+
// Regression test for https://github.com/nodejs/node-v0.x-archive/issues/5482:
943+
// should throw but not assert in C++ land.
941944
assert.throws(() => Buffer.from('', 'buffer'), TypeError);
942945

943-
// Regression test for #6111. Constructing a buffer from another buffer
944-
// should a) work, and b) not corrupt the source buffer.
946+
// Regression test for https://github.com/nodejs/node-v0.x-archive/issues/6111.
947+
// Constructing a buffer from another buffer should a) work, and b) not corrupt
948+
// the source buffer.
945949
{
946950
const a = [...Array(128).keys()]; // [0, 1, 2, 3, ... 126, 127]
947951
const b = Buffer.from(a);

‎test/parallel/test-cluster-worker-init.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ if (cluster.isMaster) {
2121
worker.send(msg);
2222
});
2323
} else {
24-
// GH #7998
24+
// https://github.com/nodejs/node-v0.x-archive/issues/7998
2525
cluster.worker.on('message', (message) => {
2626
process.send(message === msg);
2727
});

‎test/parallel/test-crypto-binary-default.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,8 @@ fileStream.on('close', common.mustCall(function() {
393393
);
394394
}));
395395

396-
// Issue #2227: unknown digest method should throw an error.
396+
// Unknown digest method should throw an error:
397+
// https://github.com/nodejs/node-v0.x-archive/issues/2227
397398
assert.throws(function() {
398399
crypto.createHash('xyzzy');
399400
}, /^Error: Digest method not supported$/);

‎test/parallel/test-crypto-cipher-decipher.js

+7-4
Original file line numberDiff line numberDiff line change
@@ -70,15 +70,16 @@ testCipher1(Buffer.from('MySecretKey123'));
7070
testCipher2('0123456789abcdef');
7171
testCipher2(Buffer.from('0123456789abcdef'));
7272

73-
// Base64 padding regression test, see #4837.
73+
// Base64 padding regression test, see
74+
// https://github.com/nodejs/node-v0.x-archive/issues/4837.
7475
{
7576
const c = crypto.createCipher('aes-256-cbc', 'secret');
7677
const s = c.update('test', 'utf8', 'base64') + c.final('base64');
7778
assert.strictEqual(s, '375oxUQCIocvxmC5At+rvA==');
7879
}
7980

8081
// Calling Cipher.final() or Decipher.final() twice should error but
81-
// not assert. See #4886.
82+
// not assert. See https://github.com/nodejs/node-v0.x-archive/issues/4886.
8283
{
8384
const c = crypto.createCipher('aes-256-cbc', 'secret');
8485
try { c.final('xxx'); } catch (e) { /* Ignore. */ }
@@ -90,14 +91,16 @@ testCipher2(Buffer.from('0123456789abcdef'));
9091
try { d.final('xxx'); } catch (e) { /* Ignore. */ }
9192
}
9293

93-
// Regression test for #5482: string to Cipher#update() should not assert.
94+
// Regression test for https://github.com/nodejs/node-v0.x-archive/issues/5482:
95+
// string to Cipher#update() should not assert.
9496
{
9597
const c = crypto.createCipher('aes192', '0123456789abcdef');
9698
c.update('update');
9799
c.final();
98100
}
99101

100-
// #5655 regression tests, 'utf-8' and 'utf8' are identical.
102+
// https://github.com/nodejs/node-v0.x-archive/issues/5655 regression tests,
103+
// 'utf-8' and 'utf8' are identical.
101104
{
102105
let c = crypto.createCipher('aes192', '0123456789abcdef');
103106
c.update('update', ''); // Defaults to "utf8".

‎test/parallel/test-crypto-hash.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,8 @@ fileStream.on('close', common.mustCall(function() {
104104
'Test SHA1 of sample.png');
105105
}));
106106

107-
// Issue #2227: unknown digest method should throw an error.
107+
// Issue https://github.com/nodejs/node-v0.x-archive/issues/2227: unknown digest
108+
// method should throw an error.
108109
assert.throws(function() {
109110
crypto.createHash('xyzzy');
110111
}, /Digest method not supported/);

‎test/parallel/test-crypto-random.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -230,8 +230,9 @@ const expectedErrorRegexp = /^TypeError: size must be a number >= 0$/;
230230
}
231231
}
232232

233-
// #5126, "FATAL ERROR: v8::Object::SetIndexedPropertiesToExternalArrayData()
234-
// length exceeds max acceptable value"
233+
// https://github.com/nodejs/node-v0.x-archive/issues/5126,
234+
// "FATAL ERROR: v8::Object::SetIndexedPropertiesToExternalArrayData() length
235+
// exceeds max acceptable value"
235236
assert.throws(function() {
236237
crypto.randomBytes((-1 >>> 0) + 1);
237238
}, /^TypeError: size must be a number >= 0$/);

‎test/parallel/test-crypto.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,8 @@ testImmutability(tls.getCiphers);
110110
testImmutability(crypto.getHashes);
111111
testImmutability(crypto.getCurves);
112112

113-
// Regression tests for #5725: hex input that's not a power of two should
114-
// throw, not assert in C++ land.
113+
// Regression tests for https://github.com/nodejs/node-v0.x-archive/pull/5725:
114+
// hex input that's not a power of two should throw, not assert in C++ land.
115115
assert.throws(function() {
116116
crypto.createCipher('aes192', 'test').update('0', 'hex');
117117
}, common.hasFipsCrypto ? /not supported in FIPS mode/ : /Bad input string/);

‎test/parallel/test-dgram-ref.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
const common = require('../common');
33
const dgram = require('dgram');
44

5-
// should not hang, see #1282
5+
// should not hang, see https://github.com/nodejs/node-v0.x-archive/issues/1282
66
dgram.createSocket('udp4');
77
dgram.createSocket('udp6');
88

‎test/parallel/test-dns-regress-7070.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@ require('../common');
33
const assert = require('assert');
44
const dns = require('dns');
55

6-
// Should not raise assertion error. Issue #7070
6+
// Should not raise assertion error.
7+
// Issue https://github.com/nodejs/node-v0.x-archive/issues/7070
78
assert.throws(() => dns.resolveNs([]), // bad name
89
/^Error: "name" argument must be a string$/);
910
assert.throws(() => dns.resolveNs(''), // bad callback

‎test/parallel/test-timers-unref.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@ const check_unref = setInterval(() => {
5050
setInterval(() => timeout.unref(), SHORT_TIME);
5151
}
5252

53-
// Should not assert on args.Holder()->InternalFieldCount() > 0. See #4261.
53+
// Should not assert on args.Holder()->InternalFieldCount() > 0.
54+
// See https://github.com/nodejs/node-v0.x-archive/issues/4261.
5455
{
5556
const t = setInterval(() => {}, 1);
5657
process.nextTick(t.unref.bind({}));

‎test/parallel/test-tls-set-encoding.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ server.listen(0, function() {
4242
client.on('close', function() {
4343
// readyState is deprecated but we want to make
4444
// sure this isn't triggering an assert in lib/net.js
45-
// See issue #1069.
45+
// See https://github.com/nodejs/node-v0.x-archive/issues/1069.
4646
assert.strictEqual('closed', client.readyState);
4747

4848
// Confirming the buffer string is encoded in ASCII

‎test/sequential/test-child-process-execsync.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,8 @@ ret = execFileSync(process.execPath, args, { encoding: 'utf8' });
7373

7474
assert.strictEqual(ret, `${msg}\n`);
7575

76-
// Verify that the cwd option works - GH #7824
76+
// Verify that the cwd option works.
77+
// See https://github.com/nodejs/node-v0.x-archive/issues/7824.
7778
{
7879
const cwd = common.rootDir;
7980
const cmd = common.isWindows ? 'echo %cd%' : 'pwd';
@@ -82,7 +83,8 @@ assert.strictEqual(ret, `${msg}\n`);
8283
assert.strictEqual(response.toString().trim(), cwd);
8384
}
8485

85-
// Verify that stderr is not accessed when stdio = 'ignore' - GH #7966
86+
// Verify that stderr is not accessed when stdio = 'ignore'.
87+
// See https://github.com/nodejs/node-v0.x-archive/issues/7966.
8688
{
8789
assert.throws(function() {
8890
execSync('exit -1', {stdio: 'ignore'});

‎test/sequential/test-module-loading.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,8 @@ const child = require('../fixtures/module-require/child/');
181181
assert.strictEqual(child.loaded, parent.loaded);
182182

183183

184-
// #1357 Loading JSON files with require()
184+
// Loading JSON files with require()
185+
// See https://github.com/nodejs/node-v0.x-archive/issues/1357.
185186
const json = require('../fixtures/packages/main/package.json');
186187
assert.deepStrictEqual(json, {
187188
name: 'package-name',
@@ -289,7 +290,8 @@ process.on('exit', function() {
289290
});
290291

291292

292-
// #1440 Loading files with a byte order marker.
293+
// Loading files with a byte order marker.
294+
// See https://github.com/nodejs/node-v0.x-archive/issues/1440.
293295
assert.strictEqual(42, require('../fixtures/utf8-bom.js'));
294296
assert.strictEqual(42, require('../fixtures/utf8-bom.json'));
295297

0 commit comments

Comments
 (0)
Please sign in to comment.