From f4e39171deb41e6d6344e5be734939b87707f433 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Sun, 13 Feb 2022 12:23:05 +0100 Subject: [PATCH] lib: restrict usage of fetch related globals in core internals MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/41957 Reviewed-By: Michaël Zasso Reviewed-By: Mestery Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Tobias Nießen Reviewed-By: Anto Aravinth Reviewed-By: Filip Skokan --- lib/.eslintrc.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml index fee5e730179c3d..882ad837fb1034 100644 --- a/lib/.eslintrc.yaml +++ b/lib/.eslintrc.yaml @@ -37,6 +37,8 @@ rules: # disabled with --no-harmony-atomics CLI flag. - name: Atomics message: Use `const { Atomics } = globalThis;` instead of the global. + - name: BroadcastChannel + message: Use `const { BroadcastChannel } = require('internal/worker/io');` instead of the global. - name: Buffer message: Use `const { Buffer } = require('buffer');` instead of the global. - name: Event @@ -57,6 +59,10 @@ rules: message: Use `const { MessageEvent } = require('internal/worker/io');` instead of the global. - name: MessagePort message: Use `const { MessagePort } = require('internal/worker/io');` instead of the global. + - name: Request + message: Use `const { Request } = require('internal/deps/undici/undici');` instead of the global. + - name: Response + message: Use `const { Response } = require('internal/deps/undici/undici');` instead of the global. # SharedArrayBuffer is not available in primordials because it can be # disabled with --no-harmony-sharedarraybuffer CLI flag. - name: SharedArrayBuffer @@ -83,6 +89,8 @@ rules: message: Use `const { Crypto } = require('internal/crypto/webcrypto');` instead of the global. - name: CryptoKey message: Use `const { CryptoKey } = require('internal/crypto/webcrypto');` instead of the global. + - name: fetch + message: Use `const { fetch } = require('internal/deps/undici/undici');` instead of the global. - name: global message: Use `const { globalThis } = primordials;` instead of `global`. - name: globalThis