Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot
Otherwise the build would fail with
`./configure --experimental-quic --ninja` as the list of per-Environment
values would not match and the code cache builder would not generate
code cache for the quic JS sources. This is more or less a band-aid -
a proper fix would be to aggregate these flags into something
that can be included by all these different binary targets.
See #31074.

PR-URL: #34454
Fixes: #34435
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
  • Loading branch information
joyeecheung authored and gengjiawen committed Jul 22, 2020
1 parent 07b3aae commit f4f191b
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions node.gyp
Expand Up @@ -1376,6 +1376,11 @@
'HAVE_OPENSSL=1',
],
}],
[ 'node_use_openssl=="true" and experimental_quic==1', {
'defines': [
'NODE_EXPERIMENTAL_QUIC=1',
],
}],
['v8_enable_inspector==1', {
'defines': [
'HAVE_INSPECTOR=1',
Expand Down Expand Up @@ -1430,6 +1435,11 @@
'HAVE_OPENSSL=1',
],
}],
[ 'node_use_openssl=="true" and experimental_quic==1', {
'defines': [
'NODE_EXPERIMENTAL_QUIC=1',
],
}],
['v8_enable_inspector==1', {
'defines': [
'HAVE_INSPECTOR=1',
Expand Down

0 comments on commit f4f191b

Please sign in to comment.