From f6f1317f438bdf7c7b0c30cba0b7e9f44e73cdc9 Mon Sep 17 00:00:00 2001 From: DeeDeeG Date: Tue, 20 Apr 2021 15:05:03 -0400 Subject: [PATCH] doc: note the system requirements for V8 tests The `test-v8` Makefile target still requires Python 2, and it requires a full Xcode install on macOS. Refs: https://github.com/nodejs/node/pull/36691 PR-URL: https://github.com/nodejs/node/pull/38319 Reviewed-By: Richard Lau Reviewed-By: James M Snell Reviewed-By: Colin Ihrig Reviewed-By: Michael Dawson --- doc/guides/maintaining-V8.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/guides/maintaining-V8.md b/doc/guides/maintaining-V8.md index 730244bc065d1f..da940758a25d94 100644 --- a/doc/guides/maintaining-V8.md +++ b/doc/guides/maintaining-V8.md @@ -229,7 +229,7 @@ to be cherry-picked in the Node.js repository and V8-CI must test the change. * Run the Node.js [V8 CI][] in addition to the [Node.js CI][]. The CI uses the `test-v8` target in the `Makefile`, which uses `tools/make-v8.sh` to reconstruct a git tree in the `deps/v8` directory to - run V8 tests. + run V8 tests2. The [`git-node`][] tool can be used to simplify this task. Run `git node v8 backport ` to cherry-pick a commit. @@ -414,6 +414,11 @@ This would require some tooling to: 1Node.js 0.12 and older are intentionally omitted from this document as their support has ended. +2The V8 tests still require Python 2. To run these tests locally, +you can run `PYTHON2 ./configure.py` before running `make test-v8`, in the root +of this repository. On macOS, this also requires a full Xcode install, +not just the "command line tools" for Xcode. + [ChromiumReleaseCalendar]: https://www.chromium.org/developers/calendar [Node.js CI]: https://ci.nodejs.org/job/node-test-pull-request/ [Node.js `canary` branch]: https://github.com/nodejs/node-v8/tree/canary